Skip to content

Fixes #RHINENG-16242 - update poetry to 2.4.1#864

Open
upadhyeammit wants to merge 1 commit into
RedHatInsights:mainfrom
upadhyeammit:RHINENG-16242
Open

Fixes #RHINENG-16242 - update poetry to 2.4.1#864
upadhyeammit wants to merge 1 commit into
RedHatInsights:mainfrom
upadhyeammit:RHINENG-16242

Conversation

@upadhyeammit

@upadhyeammit upadhyeammit commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

PR Title 💥

Please title this PR with a summary of the change, along with the JIRA card number.

Suggested formats:

  1. Fixes/Refs #RHIROS-XXX - Title
  2. RHIROS-XXX Title

Feel free to remove this section from PR description once done.

Why do we need this change? 💭

Please include the context of this change here.

Documentation update? 📝

  • Yes
  • No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

  • Bugfix
  • New Feature
  • Refactor
  • Unittests Added
  • DRY code
  • Dependency Added
  • DB Migration Added

ROS RHEL GitHub label usage for executing a desired test suite

Select the appropriate GitHub label to control which ROS RHEL backend tests run for this PR (Labels can be added before or after commits are pushed):

Note: Changing a Label on a PR with an already-tested commit will not trigger a new test run

Available ROS RHEL labels:

  • test-backend-v1: Run legacy backend tests only
  • test-backend-v2: Run new backend tests only
  • test-backend-both: Run both backend tests

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

Summary by Sourcery

Pin Poetry to version 2.4.1 across documentation, CI workflows, and Docker image, and adjust install commands to include dev dependencies.

Build:

  • Update GitHub Actions workflows to install Poetry 2.4.1 and use poetry install --with dev where appropriate.

Deployment:

  • Pin Poetry 2.4.1 in the Dockerfile via a build argument and use it for environment setup.

Documentation:

  • Refresh README files to reference Poetry 2.4.1 and document installation with dev dependencies.

@sourcery-ai

sourcery-ai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins Poetry to version 2.4.1 across local docs, CI workflows, and Docker build, and updates Poetry commands to install development dependencies explicitly.

Flow diagram for updated Poetry 2.4.1 setup and dev dependency install

flowchart TD
    Dev[Developer] --> PInstall[Install Poetry 2.4.1<br>pip install poetry==2.4.1]
    PInstall --> DepInstall[Install project deps<br>poetry install --with dev]
    DepInstall --> EnvUse[Use Poetry env<br>poetry shell / poetry run]
    EnvUse --> Tests[Run tests<br>poetry run pytest]
Loading

File-Level Changes

Change Details Files
Standardize Poetry version and usage in developer documentation.
  • Clarified that the project uses Poetry 2.4.1 and added an explicit installation command with pinned version.
  • Updated dependency installation commands to include the dev dependency group via poetry install --with dev in setup and testing instructions.
README.md
scripts/README.md
Pin Poetry version and dev-group installation in GitHub Actions workflows.
  • Changed Poetry installation in CI to install poetry==2.4.1 instead of the latest version.
  • Updated workflow dependency installation commands to use poetry install --with dev and poetry update --with dev where appropriate to ensure dev dependencies are present in CI jobs.
.github/workflows/build.yml
.github/workflows/build_with_latest_direct_deps.yml
.github/workflows/build_with_latest_indirect_deps.yml
Pin Poetry version in Docker image build.
  • Introduced a POETRY_VERSION build argument defaulting to 2.4.1.
  • Updated the Dockerfile to install Poetry with the pinned version using the new build argument while keeping Poetry in its dedicated virtual environment.
Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant