Skip to content

Add regression/db-connection-leak-valgrind#981

Draft
sergio-correia wants to merge 2 commits into
RedHat-SP-Security:mainfrom
sergio-correia:db-leaks
Draft

Add regression/db-connection-leak-valgrind#981
sergio-correia wants to merge 2 commits into
RedHat-SP-Security:mainfrom
sergio-correia:db-leaks

Conversation

@sergio-correia

@sergio-correia sergio-correia commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

This test uses valgrind and is based on the existing test
regression/db-connection-leak-reproducer.

@sourcery-ai

sourcery-ai Bot commented Dec 17, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request currently contains no functional or content changes; it appears to be a placeholder or test PR with an empty diff for plans/main.fmf.

File-Level Changes

Change Details Files
No effective changes were made; the diff is empty and the file content is unchanged.
  • File is referenced in the diff header but has no added, removed, or modified lines.
  • There is currently nothing to validate functionally or logically in the codebase for this PR.
plans/main.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
Comment thread regression/db-connection-leak-valgrind/test.sh Fixed
@sergio-correia sergio-correia changed the title DO NOT MERGE - test redirect Add regression/db-connection-leak-valgrind Jan 22, 2026

@kkaarreell kkaarreell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few nitpicks.
However, it seems that the test reports various connection leaks even for the current upstream code and not consistently.

Comment thread regression/db-connection-leak-valgrind/main.fmf Outdated
Comment thread regression/db-connection-leak-valgrind/test.sh
Comment thread regression/db-connection-leak-valgrind/test.sh
@sergio-correia
sergio-correia force-pushed the db-leaks branch 3 times, most recently from 8c6959a to e2a09b7 Compare March 30, 2026 14:27
@sergio-correia
sergio-correia force-pushed the db-leaks branch 4 times, most recently from 2e3e4b1 to f2f3458 Compare July 11, 2026 10:23
This test uses valgrind and is based on the existing test
regression/db-connection-leak-reproducer.

It reproduces scenarios that would have caused connection leaks
before the fix from PR keylime/keylime#1782.

Signed-off-by: Sergio Correia <scorreia@redhat.com>
Focus on the tests we care about.

Signed-off-by: Sergio Correia <scorreia@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants