Add regression/db-connection-leak-valgrind#981
Draft
sergio-correia wants to merge 2 commits into
Draft
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis pull request currently contains no functional or content changes; it appears to be a placeholder or test PR with an empty diff for plans/main.fmf. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
sergio-correia
marked this pull request as draft
December 17, 2025 01:36
sergio-correia
force-pushed
the
db-leaks
branch
from
January 22, 2026 19:32
b8f9b08 to
51c968b
Compare
sergio-correia
force-pushed
the
db-leaks
branch
from
January 22, 2026 19:33
51c968b to
e29f503
Compare
sergio-correia
force-pushed
the
db-leaks
branch
from
March 24, 2026 09:38
e29f503 to
e1ac256
Compare
kkaarreell
requested changes
Mar 25, 2026
kkaarreell
left a comment
Collaborator
There was a problem hiding this comment.
I have just a few nitpicks.
However, it seems that the test reports various connection leaks even for the current upstream code and not consistently.
sergio-correia
force-pushed
the
db-leaks
branch
3 times, most recently
from
March 30, 2026 14:27
8c6959a to
e2a09b7
Compare
sergio-correia
force-pushed
the
db-leaks
branch
4 times, most recently
from
July 11, 2026 10:23
2e3e4b1 to
f2f3458
Compare
This test uses valgrind and is based on the existing test regression/db-connection-leak-reproducer. It reproduces scenarios that would have caused connection leaks before the fix from PR keylime/keylime#1782. Signed-off-by: Sergio Correia <scorreia@redhat.com>
Focus on the tests we care about. Signed-off-by: Sergio Correia <scorreia@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test uses valgrind and is based on the existing test
regression/db-connection-leak-reproducer.