Skip to content

Fix SELinux module definition#1104

Merged
kkaarreell merged 1 commit into
rhel-10-mainfrom
backport/20260723090102_rhel-10-main
Jul 23, 2026
Merged

Fix SELinux module definition#1104
kkaarreell merged 1 commit into
rhel-10-mainfrom
backport/20260723090102_rhel-10-main

Conversation

@kkaarreell

@kkaarreell kkaarreell commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

On Rawhide loading of compiled module started to fail with:
#semodule -i swtpm_permissive.pp'
Failed to resolve typeattributeset statement at /var/lib/selinux/targeted/tmp/modules/400/swtpm_permissive/cil:2
Failed to resolve AST
semodule: Failed!

Summary by Sourcery

Bug Fixes:

  • Resolve SELinux module definition issues that caused semodule installation of swtpm_permissive.pp to fail on Rawhide.

On Rawhide loading of compiled module started to fail with:
  #semodule -i swtpm_permissive.pp'
  Failed to resolve typeattributeset statement at /var/lib/selinux/targeted/tmp/modules/400/swtpm_permissive/cil:2
  Failed to resolve AST
  semodule:  Failed!
@kkaarreell kkaarreell self-assigned this Jul 23, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the SELinux policy module definition for swtpm_permissive so it compiles and loads correctly on Rawhide by fixing an invalid/unsupported typeattributeset usage in the .te file.

File-Level Changes

Change Details Files
Correct SELinux policy constructs in swtpm_permissive module so semodule -i succeeds on Rawhide.
  • Update the swtpm_permissive SELinux type/attribute declarations to use valid, resolvable typeattributeset syntax.
  • Align policy statements with current SELinux/CIL expectations to avoid AST resolution failures during module installation.
setup/configure_tpm_emulator/swtpm_permissive.te

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kkaarreell

Copy link
Copy Markdown
Collaborator Author

test failure is unrelated. The selinux module issue is fixed.

@kkaarreell
kkaarreell merged commit e48bcb9 into rhel-10-main Jul 23, 2026
4 of 5 checks passed
@kkaarreell
kkaarreell deleted the backport/20260723090102_rhel-10-main branch July 23, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant