Fix flaky --max-workers strace assertion on aarch64#1102
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe test for keylime-policy --max-workers has been made more deterministic and robust by counting only process forks from the main keylime-policy PID in strace output and widening the worker count comparison from 1 vs 3 to 1 vs 5. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Count only process forks (SIGCHLD) from the main keylime-policy PID instead of all clone/clone3 lines, filtering out non-deterministic thread creation in child processes. Also widen the gap by comparing --max-workers 1 vs 5 (difference of 4 forks) instead of 1 vs 3 (difference of 2). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ting The strace approach to verify --max-workers was architecture-dependent: clone syscall output format differs between x86_64 and aarch64, causing false negatives. Instead, use a stalling HTTP server that serves repodata normally but holds RPM download connections open, then count established TCP connections with ss to verify worker parallelism. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kkaarreell
force-pushed
the
backport/20260722134729_rhel-9-main
branch
from
July 23, 2026 06:38
cd1db39 to
c313f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count only process forks (SIGCHLD) from the main keylime-policy PID instead of all clone/clone3 lines, filtering out non-deterministic thread creation in child processes. Also widen the gap by comparing --max-workers 1 vs 5 (difference of 4 forks) instead of 1 vs 3 (difference of 2).
Summary by Sourcery
Stabilize the keylime-policy --max-workers functional test by making the strace-based worker count deterministic and adjusting the comparison to a larger worker difference.
Bug Fixes:
Tests: