Skip to content

New test for postgresql pushmodel regression#1098

Merged
kkaarreell merged 1 commit into
mainfrom
nb_posgresqil_pushmodel_main
Jul 22, 2026
Merged

New test for postgresql pushmodel regression#1098
kkaarreell merged 1 commit into
mainfrom
nb_posgresqil_pushmodel_main

Conversation

@4N0body5

@4N0body5 4N0body5 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Add a functional test that validates push-model attestation works correctly with a PostgreSQL-backed verifier and registrar, including regression coverage for column truncation errors.

Tests:

  • Introduce a new BeakerLib-based functional test scenario that provisions PostgreSQL, configures Keylime for push-model attestation, and verifies successful agent attestation.
  • Add regression verification ensuring no StringDataRightTruncation errors occur in the PostgreSQL verifier log when using push-model attestation.
  • Include accompanying FMF metadata and PostgreSQL setup script for the new push-model-with-PostgreSQL functional test.

@sourcery-ai

sourcery-ai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds a new functional test that validates Keylime push-model attestation works correctly when verifier and registrar use a PostgreSQL backend, and that a previous column-size regression does not reoccur.

File-Level Changes

Change Details Files
Introduce a Beakerlib-based functional test that configures PostgreSQL for Keylime verifier/registrar, runs push-model attestation, and asserts successful behavior without regression errors.
  • Set up PostgreSQL from a clean data directory, adjust pg_hba.conf for md5 auth, and initialize Keylime-specific databases via a setup SQL script
  • Update Keylime verifier, registrar, and agent configuration to use PostgreSQL and push-model parameters including attestation/quote intervals and authentication flags
  • Conditionally start TPM and IMA emulators when needed, then start verifier and registrar services and validate that expected PostgreSQL databases exist
  • Enroll a push-model agent, add it via keylime_tenant with a runtime policy, wait for a PASS attestation status within a timeout, and assert absence of StringDataRightTruncation in verifier logs
  • Implement cleanup steps to stop services/emulators, restore configs and files, and submit common logs
functional/push-model-attestation-with-postgresql-db/test.sh
Add test metadata and database setup SQL for the new PostgreSQL push-model attestation functional test.
  • Provide FMF metadata for the new functional test, integrating it into the test suite
  • Define SQL to create and grant access to verifier and registrar PostgreSQL databases and users used by the test
functional/push-model-attestation-with-postgresql-db/main.fmf
functional/push-model-attestation-with-postgresql-db/setup.psql

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@@ -0,0 +1,98 @@
#!/bin/bash
# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
. /usr/share/beakerlib/beakerlib.sh || exit 1

rlRun -s "sudo -u postgres psql -c 'SELECT datname FROM pg_database;'"
rlAssertGrep "verifierdb" $rlRun_LOG
rlAssertGrep "registrardb" $rlRun_LOG

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@4N0body5
4N0body5 requested a review from kkaarreell July 21, 2026 16:21
@kkaarreell
kkaarreell merged commit a5dd16b into main Jul 22, 2026
6 of 9 checks passed
@kkaarreell
kkaarreell deleted the nb_posgresqil_pushmodel_main branch July 22, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants