fix: -fno-sanitize-recover so sanitizer errors fail the build#24
Merged
Conversation
UBSan recovers by default (prints the error, continues, exits 0), so a sanitize=undefined build passes green despite real UB. Add -fno-sanitize-recover (matching the enabled set) for gcc/clang so the first sanitizer error aborts the build. Verified harmless for address/thread/leak. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
RedFox20
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UBSan recovers by default — it prints the error, continues, and exits 0. So a
sanitize=undefinedbuild passes green despite real UB. This adds-fno-sanitize-recover(matching the enabled sanitizer set) for gcc/clang, so the first sanitizer error aborts the build.Verified
mama ubsan build teston a target with a misaligned read:runtime error: load of misaligned address …printed, exit 0 (green)Harmless for
address/thread/leak— all accept the flag (tested). One line, mirrors the existing-fsanitizeinjection just above.🤖 Generated with Claude Code