Skip to content

[ACEM] llteacher x ruff format#117

Open
automaticcodeevolutionmanagement[bot] wants to merge 1 commit into
mainfrom
acem/ruff-format-0.14.8-20260606-183724
Open

[ACEM] llteacher x ruff format#117
automaticcodeevolutionmanagement[bot] wants to merge 1 commit into
mainfrom
acem/ruff-format-0.14.8-20260606-183724

Conversation

@automaticcodeevolutionmanagement

@automaticcodeevolutionmanagement automaticcodeevolutionmanagement Bot commented Jun 6, 2026

Copy link
Copy Markdown

llteacher x ruff format

Details

  • Policy: Ruff Format 0.14.8
  • Initiative ID: 24
  • Fixes Applied: 4 violations
  • Files Modified: 4

Original Violations

src/accounts/canvas_service.py 
--- src/accounts/canvas_service.py
+++ src/accounts/canvas_service.py
@@ -52,9 +52,7 @@
 
         base_url = self._settings.CANVAS_BASE_URL.rstrip("/")
         client_id = self._settings.CANVAS_CLIENT_ID
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
         scopes = getattr(self._settings, "CANVAS_OAUTH_SCOPES", "")
 
         params = (

--- src/accounts/migrations/0004_add_canvas_profile.py
+++ src/accounts/migrations/0004_add_canvas_profile.py
@@ -7,25 +7,39 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
-        ('accounts', '0003_teacherassistant'),
+        ("accounts", "0003_teacherassistant"),
     ]
 
     operations = [
         migrations.CreateModel(
-            name='CanvasProfile',
+            name="CanvasProfile",
             fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, primary_key=True, serialize=False)),
-                ('canvas_user_id', models.CharField(max_length=64, unique=True)),
-                ('access_token', models.CharField(blank=True, max_length=255)),
-                ('refresh_token', models.CharField(blank=True, max_length=255)),
-                ('created_at', models.DateTimeField(auto_now_add=True)),
-                ('updated_at', models.DateTimeField(auto_now=True)),
-                ('user', models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, related_name='canvas_profile', to=settings.AUTH_USER_MODEL)),
+                (
+                    "id",
+                    models.UUIDField(
+                        default=uuid.uuid4,
+                        editable=False,
+                        primary_key=True,
+                        serialize=False,
+                    ),
+                ),
+                ("canvas_user_id", models.CharField(max_length=64, unique=True)),
+                ("access_token", models.CharField(blank=True, max_length=255)),
+                ("refresh_token", models.CharField(blank=True, max_length=255)),
+                ("created_at", models.DateTimeField(auto_now_add=True)),
+                ("updated_at", models.DateTimeField(auto_now=True)),
+                (
+                    "user",
+                    models.OneToOneField(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="canvas_profile",
+                        to=settings.AUTH_USER_MODEL,
+                    ),
+                ),
             ],
             options={
-                'db_table': 'accounts_canvas_profile',
+                "db_table": "accounts_canvas_profile",
             },
         ),
     ]

--- src/accounts/tests/test_canvas_oauth.py
+++ src/accounts/tests/test_canvas_oauth.py
@@ -34,9 +34,7 @@
         self.assertTrue(user.is_email_verified)
         self.assertTrue(hasattr(user, "student_profile"))
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="100", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="100", user=user).exists()
         )
 
     def test_returns_existing_user_by_canvas_user_id(self):
@@ -53,9 +51,7 @@
         self.assertEqual(result.id, user.id)
 
     def test_links_existing_user_by_email(self):
-        user = User.objects.create_user(
-            username="link@uw.edu", email="link@uw.edu"
-        )
+        user = User.objects.create_user(username="link@uw.edu", email="link@uw.edu")
 
         info = CanvasUserInfo(
             canvas_user_id="300", name="Link User", email="link@uw.edu"
@@ -64,9 +60,7 @@
         self.assertFalse(created)
         self.assertEqual(result.id, user.id)
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="300", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="300", user=user).exists()
         )
 
     def test_handles_missing_email_with_login_id(self):
@@ -221,9 +215,7 @@
         self.assertIn("state=", response.url)
         self.assertIn("redirect_uri=", response.url)
         self.assertIn("scope=", response.url)
-        self.assertIn(
-            "url:GET%7C/api/v1/users/self", response.url
-        )
+        self.assertIn("url:GET%7C/api/v1/users/self", response.url)
 
     def test_redirects_home_when_already_authenticated(self):
         user = User.objects.create_user(username="test@uw.edu", password="pw123")

--- src/accounts/views.py
+++ src/accounts/views.py
@@ -458,7 +458,8 @@
 
         if not self._service._settings.CANVAS_CLIENT_ID:
             messages.error(
-                request, "Canvas login is not configured. Please use email/password instead."
+                request,
+                "Canvas login is not configured. Please use email/password instead.",
             )
             return redirect("accounts:login")
 
@@ -502,13 +503,9 @@
 
         if not self._service.verify_state(request, state):
             logger.warning("Canvas OAuth2 state verification failed")
-            return CanvasCallbackError(
-                error="Authentication failed. Please try again."
-            )
+            return CanvasCallbackError(error="Authentication failed. Please try again.")
 
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
 
         token_result = self._service.exchange_code(code, redirect_uri)
         if not token_result.success:
src/accounts/migrations/0004_add_canvas_profile.py 
--- src/accounts/canvas_service.py
+++ src/accounts/canvas_service.py
@@ -52,9 +52,7 @@
 
         base_url = self._settings.CANVAS_BASE_URL.rstrip("/")
         client_id = self._settings.CANVAS_CLIENT_ID
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
         scopes = getattr(self._settings, "CANVAS_OAUTH_SCOPES", "")
 
         params = (

--- src/accounts/migrations/0004_add_canvas_profile.py
+++ src/accounts/migrations/0004_add_canvas_profile.py
@@ -7,25 +7,39 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
-        ('accounts', '0003_teacherassistant'),
+        ("accounts", "0003_teacherassistant"),
     ]
 
     operations = [
         migrations.CreateModel(
-            name='CanvasProfile',
+            name="CanvasProfile",
             fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, primary_key=True, serialize=False)),
-                ('canvas_user_id', models.CharField(max_length=64, unique=True)),
-                ('access_token', models.CharField(blank=True, max_length=255)),
-                ('refresh_token', models.CharField(blank=True, max_length=255)),
-                ('created_at', models.DateTimeField(auto_now_add=True)),
-                ('updated_at', models.DateTimeField(auto_now=True)),
-                ('user', models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, related_name='canvas_profile', to=settings.AUTH_USER_MODEL)),
+                (
+                    "id",
+                    models.UUIDField(
+                        default=uuid.uuid4,
+                        editable=False,
+                        primary_key=True,
+                        serialize=False,
+                    ),
+                ),
+                ("canvas_user_id", models.CharField(max_length=64, unique=True)),
+                ("access_token", models.CharField(blank=True, max_length=255)),
+                ("refresh_token", models.CharField(blank=True, max_length=255)),
+                ("created_at", models.DateTimeField(auto_now_add=True)),
+                ("updated_at", models.DateTimeField(auto_now=True)),
+                (
+                    "user",
+                    models.OneToOneField(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="canvas_profile",
+                        to=settings.AUTH_USER_MODEL,
+                    ),
+                ),
             ],
             options={
-                'db_table': 'accounts_canvas_profile',
+                "db_table": "accounts_canvas_profile",
             },
         ),
     ]

--- src/accounts/tests/test_canvas_oauth.py
+++ src/accounts/tests/test_canvas_oauth.py
@@ -34,9 +34,7 @@
         self.assertTrue(user.is_email_verified)
         self.assertTrue(hasattr(user, "student_profile"))
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="100", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="100", user=user).exists()
         )
 
     def test_returns_existing_user_by_canvas_user_id(self):
@@ -53,9 +51,7 @@
         self.assertEqual(result.id, user.id)
 
     def test_links_existing_user_by_email(self):
-        user = User.objects.create_user(
-            username="link@uw.edu", email="link@uw.edu"
-        )
+        user = User.objects.create_user(username="link@uw.edu", email="link@uw.edu")
 
         info = CanvasUserInfo(
             canvas_user_id="300", name="Link User", email="link@uw.edu"
@@ -64,9 +60,7 @@
         self.assertFalse(created)
         self.assertEqual(result.id, user.id)
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="300", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="300", user=user).exists()
         )
 
     def test_handles_missing_email_with_login_id(self):
@@ -221,9 +215,7 @@
         self.assertIn("state=", response.url)
         self.assertIn("redirect_uri=", response.url)
         self.assertIn("scope=", response.url)
-        self.assertIn(
-            "url:GET%7C/api/v1/users/self", response.url
-        )
+        self.assertIn("url:GET%7C/api/v1/users/self", response.url)
 
     def test_redirects_home_when_already_authenticated(self):
         user = User.objects.create_user(username="test@uw.edu", password="pw123")

--- src/accounts/views.py
+++ src/accounts/views.py
@@ -458,7 +458,8 @@
 
         if not self._service._settings.CANVAS_CLIENT_ID:
             messages.error(
-                request, "Canvas login is not configured. Please use email/password instead."
+                request,
+                "Canvas login is not configured. Please use email/password instead.",
             )
             return redirect("accounts:login")
 
@@ -502,13 +503,9 @@
 
         if not self._service.verify_state(request, state):
             logger.warning("Canvas OAuth2 state verification failed")
-            return CanvasCallbackError(
-                error="Authentication failed. Please try again."
-            )
+            return CanvasCallbackError(error="Authentication failed. Please try again.")
 
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
 
         token_result = self._service.exchange_code(code, redirect_uri)
         if not token_result.success:
src/accounts/tests/test_canvas_oauth.py 
--- src/accounts/canvas_service.py
+++ src/accounts/canvas_service.py
@@ -52,9 +52,7 @@
 
         base_url = self._settings.CANVAS_BASE_URL.rstrip("/")
         client_id = self._settings.CANVAS_CLIENT_ID
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
         scopes = getattr(self._settings, "CANVAS_OAUTH_SCOPES", "")
 
         params = (

--- src/accounts/migrations/0004_add_canvas_profile.py
+++ src/accounts/migrations/0004_add_canvas_profile.py
@@ -7,25 +7,39 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
-        ('accounts', '0003_teacherassistant'),
+        ("accounts", "0003_teacherassistant"),
     ]
 
     operations = [
         migrations.CreateModel(
-            name='CanvasProfile',
+            name="CanvasProfile",
             fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, primary_key=True, serialize=False)),
-                ('canvas_user_id', models.CharField(max_length=64, unique=True)),
-                ('access_token', models.CharField(blank=True, max_length=255)),
-                ('refresh_token', models.CharField(blank=True, max_length=255)),
-                ('created_at', models.DateTimeField(auto_now_add=True)),
-                ('updated_at', models.DateTimeField(auto_now=True)),
-                ('user', models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, related_name='canvas_profile', to=settings.AUTH_USER_MODEL)),
+                (
+                    "id",
+                    models.UUIDField(
+                        default=uuid.uuid4,
+                        editable=False,
+                        primary_key=True,
+                        serialize=False,
+                    ),
+                ),
+                ("canvas_user_id", models.CharField(max_length=64, unique=True)),
+                ("access_token", models.CharField(blank=True, max_length=255)),
+                ("refresh_token", models.CharField(blank=True, max_length=255)),
+                ("created_at", models.DateTimeField(auto_now_add=True)),
+                ("updated_at", models.DateTimeField(auto_now=True)),
+                (
+                    "user",
+                    models.OneToOneField(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="canvas_profile",
+                        to=settings.AUTH_USER_MODEL,
+                    ),
+                ),
             ],
             options={
-                'db_table': 'accounts_canvas_profile',
+                "db_table": "accounts_canvas_profile",
             },
         ),
     ]

--- src/accounts/tests/test_canvas_oauth.py
+++ src/accounts/tests/test_canvas_oauth.py
@@ -34,9 +34,7 @@
         self.assertTrue(user.is_email_verified)
         self.assertTrue(hasattr(user, "student_profile"))
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="100", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="100", user=user).exists()
         )
 
     def test_returns_existing_user_by_canvas_user_id(self):
@@ -53,9 +51,7 @@
         self.assertEqual(result.id, user.id)
 
     def test_links_existing_user_by_email(self):
-        user = User.objects.create_user(
-            username="link@uw.edu", email="link@uw.edu"
-        )
+        user = User.objects.create_user(username="link@uw.edu", email="link@uw.edu")
 
         info = CanvasUserInfo(
             canvas_user_id="300", name="Link User", email="link@uw.edu"
@@ -64,9 +60,7 @@
         self.assertFalse(created)
         self.assertEqual(result.id, user.id)
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="300", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="300", user=user).exists()
         )
 
     def test_handles_missing_email_with_login_id(self):
@@ -221,9 +215,7 @@
         self.assertIn("state=", response.url)
         self.assertIn("redirect_uri=", response.url)
         self.assertIn("scope=", response.url)
-        self.assertIn(
-            "url:GET%7C/api/v1/users/self", response.url
-        )
+        self.assertIn("url:GET%7C/api/v1/users/self", response.url)
 
     def test_redirects_home_when_already_authenticated(self):
         user = User.objects.create_user(username="test@uw.edu", password="pw123")

--- src/accounts/views.py
+++ src/accounts/views.py
@@ -458,7 +458,8 @@
 
         if not self._service._settings.CANVAS_CLIENT_ID:
             messages.error(
-                request, "Canvas login is not configured. Please use email/password instead."
+                request,
+                "Canvas login is not configured. Please use email/password instead.",
             )
             return redirect("accounts:login")
 
@@ -502,13 +503,9 @@
 
         if not self._service.verify_state(request, state):
             logger.warning("Canvas OAuth2 state verification failed")
-            return CanvasCallbackError(
-                error="Authentication failed. Please try again."
-            )
+            return CanvasCallbackError(error="Authentication failed. Please try again.")
 
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
 
         token_result = self._service.exchange_code(code, redirect_uri)
         if not token_result.success:
src/accounts/views.py 
--- src/accounts/canvas_service.py
+++ src/accounts/canvas_service.py
@@ -52,9 +52,7 @@
 
         base_url = self._settings.CANVAS_BASE_URL.rstrip("/")
         client_id = self._settings.CANVAS_CLIENT_ID
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
         scopes = getattr(self._settings, "CANVAS_OAUTH_SCOPES", "")
 
         params = (

--- src/accounts/migrations/0004_add_canvas_profile.py
+++ src/accounts/migrations/0004_add_canvas_profile.py
@@ -7,25 +7,39 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
-        ('accounts', '0003_teacherassistant'),
+        ("accounts", "0003_teacherassistant"),
     ]
 
     operations = [
         migrations.CreateModel(
-            name='CanvasProfile',
+            name="CanvasProfile",
             fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, primary_key=True, serialize=False)),
-                ('canvas_user_id', models.CharField(max_length=64, unique=True)),
-                ('access_token', models.CharField(blank=True, max_length=255)),
-                ('refresh_token', models.CharField(blank=True, max_length=255)),
-                ('created_at', models.DateTimeField(auto_now_add=True)),
-                ('updated_at', models.DateTimeField(auto_now=True)),
-                ('user', models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, related_name='canvas_profile', to=settings.AUTH_USER_MODEL)),
+                (
+                    "id",
+                    models.UUIDField(
+                        default=uuid.uuid4,
+                        editable=False,
+                        primary_key=True,
+                        serialize=False,
+                    ),
+                ),
+                ("canvas_user_id", models.CharField(max_length=64, unique=True)),
+                ("access_token", models.CharField(blank=True, max_length=255)),
+                ("refresh_token", models.CharField(blank=True, max_length=255)),
+                ("created_at", models.DateTimeField(auto_now_add=True)),
+                ("updated_at", models.DateTimeField(auto_now=True)),
+                (
+                    "user",
+                    models.OneToOneField(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="canvas_profile",
+                        to=settings.AUTH_USER_MODEL,
+                    ),
+                ),
             ],
             options={
-                'db_table': 'accounts_canvas_profile',
+                "db_table": "accounts_canvas_profile",
             },
         ),
     ]

--- src/accounts/tests/test_canvas_oauth.py
+++ src/accounts/tests/test_canvas_oauth.py
@@ -34,9 +34,7 @@
         self.assertTrue(user.is_email_verified)
         self.assertTrue(hasattr(user, "student_profile"))
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="100", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="100", user=user).exists()
         )
 
     def test_returns_existing_user_by_canvas_user_id(self):
@@ -53,9 +51,7 @@
         self.assertEqual(result.id, user.id)
 
     def test_links_existing_user_by_email(self):
-        user = User.objects.create_user(
-            username="link@uw.edu", email="link@uw.edu"
-        )
+        user = User.objects.create_user(username="link@uw.edu", email="link@uw.edu")
 
         info = CanvasUserInfo(
             canvas_user_id="300", name="Link User", email="link@uw.edu"
@@ -64,9 +60,7 @@
         self.assertFalse(created)
         self.assertEqual(result.id, user.id)
         self.assertTrue(
-            CanvasProfile.objects.filter(
-                canvas_user_id="300", user=user
-            ).exists()
+            CanvasProfile.objects.filter(canvas_user_id="300", user=user).exists()
         )
 
     def test_handles_missing_email_with_login_id(self):
@@ -221,9 +215,7 @@
         self.assertIn("state=", response.url)
         self.assertIn("redirect_uri=", response.url)
         self.assertIn("scope=", response.url)
-        self.assertIn(
-            "url:GET%7C/api/v1/users/self", response.url
-        )
+        self.assertIn("url:GET%7C/api/v1/users/self", response.url)
 
     def test_redirects_home_when_already_authenticated(self):
         user = User.objects.create_user(username="test@uw.edu", password="pw123")

--- src/accounts/views.py
+++ src/accounts/views.py
@@ -458,7 +458,8 @@
 
         if not self._service._settings.CANVAS_CLIENT_ID:
             messages.error(
-                request, "Canvas login is not configured. Please use email/password instead."
+                request,
+                "Canvas login is not configured. Please use email/password instead.",
             )
             return redirect("accounts:login")
 
@@ -502,13 +503,9 @@
 
         if not self._service.verify_state(request, state):
             logger.warning("Canvas OAuth2 state verification failed")
-            return CanvasCallbackError(
-                error="Authentication failed. Please try again."
-            )
+            return CanvasCallbackError(error="Authentication failed. Please try again.")
 
-        redirect_uri = request.build_absolute_uri(
-            reverse("accounts:canvas_callback")
-        )
+        redirect_uri = request.build_absolute_uri(reverse("accounts:canvas_callback"))
 
         token_result = self._service.exchange_code(code, redirect_uri)
         if not token_result.success:
---

This pull request was automatically created by ACEM.

[ACEM] llteacher x ruff format
363723a 
Policy: Ruff Format 0.14.8
Fixed: 4 violations

Original Violations:

Formatted 4 file(s):
  - src/accounts/canvas_service.py
  - src/accounts/migrations/0004_add_canvas_profile.py
  - src/accounts/tests/test_canvas_oauth.py
  - src/accounts/views.py

Automated by ACEM - Initiative #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants