Allow teachers/TAs to try conversations safely#114
Merged
Conversation
- Fix broken conversation links in section_detail template (was href='#') - Add 'Try Conversation' button for teachers on homework detail page - Add 'Test Conversation' button for TAs on homework detail page - List old test conversations below the button for resuming - Guard all student_profile accesses against teacher/TA test conversations (get_all_homework_matrix, get_course_homework_matrix, Submission.student, get_submission_data) - Add 4 tests covering teacher test conversations in matrix, submission, and model edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
href='#')get_all_homework_matrixandget_course_homework_matrixSubmission.studentpropertyget_submission_dataTesting
All 855 tests pass, ruff formatting/lint and mypy type checking are clean.