feat(buy): hint savings plan can be set up recurring and multiple times#686
Open
TaprootFreak wants to merge 3 commits into
Open
feat(buy): hint savings plan can be set up recurring and multiple times#686TaprootFreak wants to merge 3 commits into
TaprootFreak wants to merge 3 commits into
Conversation
Surface the standing-order / multi-plan autoinvest capability on the Zahlungsdetails page (post-confirm bank-transfer instructions), which is where the IBAN/BIC details now live after the payment-details rework. Add buyRecurringPaymentHint (de+en) and cover it in the page widget test.
TaprootFreak
force-pushed
the
feature/autoinvest-recurring-hints
branch
from
b2264b4 to
1c0f05a
Compare
Refresh Zahlungsdetails goldens after adding the recurring standing-order hint row. Baselines taken from the self-hosted VR runner (testImage).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part of #666 (RealUnit Phase 2), Baustein 4: Autoinvest / Sparplan. Closes #685.
The autoinvest/savings-plan feature is functionally complete. This PR adds the remaining frontend hint: telling the user that the RealUnit purchase can be set up recurring (a bank standing order / Dauerauftrag) and multiple times (several plans in parallel).
What changed
lib/screens/buy/widgets/payment_information_details.dart— on the buy payment-information screen (the screen that shows the IBAN/BIC for the bank transfer). The hint is rendered directly below the existing payment-information description, reusing the same info-row layout (Icons.autorenewinRealUnitColors.realUnitBlue,Theme.textTheme.bodyMedium,spacing: 12).buyRecurringPaymentHintin bothstrings_de.arbandstrings_en.arb(alphabetically placed):test/screens/buy/widgets/payment_information_details_test.dartasserts the hint text and theautorenewicon (colour + size) render. Existingpayment_information_test.dartunchanged and green.buy_payment_info_loadedbaseline changes (the new hint row). Regenerated viagolden-regenerate.yamlon this branch (dfx01). No new handbook page — this is a changed existing page, so only its existing baseline is refreshed; noscripts/assemble-handbook-screenshots.shrow change needed.Scope notes
Local gates
flutter analyze→ No issues foundflutter test --coverage --exclude-tags golden→ 2307 passed; scoped lines 4874/4874 = 100%dart format --page-width=100on touched files → clean