This repository was archived by the owner on Mar 1, 2025. It is now read-only.
fix hierarchy of button and anchor tag#523
Open
mayurlalwani wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mayurlalwani
force-pushed
the
fix/button-link-hierarchy
branch
from
379bffb to
bf5941e
Compare
shubhamsinghbundela
left a comment
shubhamsinghbundela
left a comment
There was a problem hiding this comment.
great work @mayurlalwani...not find anything wrong
RitikJaiswal75
approved these changes
Jun 2, 2023
Author
@shubhamsigdar1 Can you please approve this PR so that it can be merged |
Author
|
@RitikJaiswal75 Can you merge this PR as 2 members have approved? |
RitikJaiswal75
suggested changes
Jun 20, 2023
RitikJaiswal75
left a comment
RitikJaiswal75
left a comment
Contributor
There was a problem hiding this comment.
Please write tests for it
iamitprakash
suggested changes
Jun 20, 2023
iamitprakash
left a comment
iamitprakash
left a comment
Member
There was a problem hiding this comment.
Please add PR details shared by @RitikJaiswal75 and add two images for before and After
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
The change was to fix the heirarchy of button and anchor tag. So I used div element instead of anchor tag.
Is it bug?
It is not a bug, as it is not breaking anything. The issue is about refactoring and using HTML standard practices.
*Dev Tested?
*Tested on:
Platforms
Browsers
Before / After Change Screenshots
Issue: #488