Conversation
Support `no_std` (again)
There was a problem hiding this comment.
Pull Request Overview
This PR adds no_std support to the codebase, allowing it to be used in environments without the standard library by switching to core types and allocator-based collections.
Key changes:
- Add
#![no_std]attribute and conditionalstdfeature - Replace
std::types withcore::equivalents for basic functionality - Import
alloc::vec::Vecfor heap-allocated collections
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Adds no_std attribute and conditional std extern crate |
| src/error.rs | Replaces std types with core equivalents for error handling |
| src/models/output_data.rs | Updates Display trait implementation to use core::fmt |
| src/models/types.rs | Adds alloc imports for Vec usage |
| src/models/archived.rs | Adds alloc::vec::Vec import |
| src/deserializer/typedstream.rs | Adds alloc imports for collections |
| src/deserializer/string.rs | Updates string parsing to use core::str |
| src/deserializer/iter.rs | Updates iterator types and adds std feature guards for print functions |
| src/deserializer/header.rs | Updates test imports for no_std compatibility |
| src/deserializer/consumed.rs | Replaces std::ops with core::ops for Deref traits |
| Cargo.toml | Adds std feature flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
Author
|
Seems reasonable; no performance impact in my testing. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no_stdfor Supportno_std#10 (Contributed by @gkgoat1)