Homework typescript#114
Open
SergeyArtsiomau wants to merge 9 commits into
Open
Conversation
added 8 commits
June 9, 2026 17:02
AlexandrLitkevich
suggested changes
Jun 11, 2026
| import './layout.css'; | ||
|
|
||
| export interface LayoutProps { | ||
| logoTitle?: string; |
There was a problem hiding this comment.
Зачем делать опциональные поля?Компонент рисует Layout и они необходимы, default props только путаницу создают
Author
There was a problem hiding this comment.
Согласен, убрал ? и default props. logoTitle, headerContent и children теперь обязательные
| } | ||
|
|
||
| export function AddToCartButton({ count = 0, disabled = false }: AddToCartButtonProps) { | ||
| if (count <= 0) { |
There was a problem hiding this comment.
Разве count может быть отрицательным?
Author
There was a problem hiding this comment.
Согласен, отрицательное количество для кнопки не предусмотрено
| } | ||
|
|
||
| export function AddToCartButton({ count = 0, disabled = false }: AddToCartButtonProps) { | ||
| if (count <= 0) { |
There was a problem hiding this comment.
Suggested change
| if (count <= 0) { | |
| if (!count) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.