fix(Root install): Change SELinux context to match stock APK before mounting#3433
Open
PalmDevs wants to merge 1 commit into
Open
fix(Root install): Change SELinux context to match stock APK before mounting#3433PalmDevs wants to merge 1 commit into
PalmDevs wants to merge 1 commit into
Conversation
PalmDevs
changed the title
Member
|
The change should be made in revanced-library as its installer shouldve been used instead of a manager specific implementation. Otherwise CLI is not receiving this PR. |
Member
Author
|
For now since Manager doesn't use library for root installation, this PR should be merged. Another PR can be made to library after. |
Member
|
The source of truth should always be library if at all. The mistake here is at managers side not using library after all. If at all, we can synchronize the changes back to manager, but at the very least changes should go to library, because then manager can simply switch to it without us having to port changes to Library first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3428