Fix Electron desktop boot (missing node_modules) - #31
Merged
Conversation
electron-builder was omitting node_modules via .gitignore, so the Windows app quit silently after install. Also surface splash/errors and write desktop.log.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Skip shipping electron tooling in the desktop runtime, use a fresh stage dir, compile preload as CJS, and fall back to a junction when Windows locks the _node_modules rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignore, so packaged desktops shipped withoutnode_modules. Bridge crashed oncors, host exited, Electron quit with no UI._node_modules, rename back inafterPack, and fail the build ifcorsis missing.%APPDATA%\GodMode\logs\desktop.log.GodModeinstead of@godmodedesktop.Test plan
npm run build -w @godmode/desktopnpm run test:releasedesktop.logDo not rely on the current nightly installer — it is broken.