Update tsdown config for treaty types#77
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughMigrated package type declarations to separate ESM/CJS outputs, added a new tsdown build entry for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 19 19
Lines 2765 2765
=======================================
Hits 2660 2660
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/zenko/package.json (1)
32-33: Optional cleanup: remove legacy.d.tspublish glob if no longer emitted.If the package has fully migrated to
.d.mts/.d.cts, keepingdist/**/*.d.tscan be dropped to reduce ambiguity.Proposed cleanup
"files": [ "LICENSE", "README.md", "dist/**/*.cjs", "dist/**/*.d.cts", "dist/**/*.d.mts", - "dist/**/*.d.ts", "dist/**/*.mjs" ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/zenko/package.json` around lines 32 - 33, The publish file-glob "dist/**/*.d.ts" is legacy if the package now emits only ".d.mts"/".d.cts"; remove the "dist/**/*.d.ts" entry from package.json (the pattern alongside "dist/**/*.d.mts") to avoid publishing obsolete type artifacts and ambiguity—ensure the remaining globs ("dist/**/*.d.mts" and any ".d.cts" patterns) cover all emitted declaration files before committing the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/zenko/package.json`:
- Around line 32-33: The publish file-glob "dist/**/*.d.ts" is legacy if the
package now emits only ".d.mts"/".d.cts"; remove the "dist/**/*.d.ts" entry from
package.json (the pattern alongside "dist/**/*.d.mts") to avoid publishing
obsolete type artifacts and ambiguity—ensure the remaining globs
("dist/**/*.d.mts" and any ".d.cts" patterns) cover all emitted declaration
files before committing the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f6f91961-299c-43f6-a998-4fbaabf57a64
📒 Files selected for processing (3)
packages/examples/tsconfig.jsonpackages/zenko/package.jsonpackages/zenko/tsdown.config.ts
💤 Files with no reviewable changes (1)
- packages/examples/tsconfig.json
Summary by CodeRabbit