Charged attack changes#124
Open
JorxPi wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was adressing the following task: https://app.notion.com/p/32cb5bde334a80088f14c3797dfff605?v=35db5bde334a807ab4fd000c0ea45edd&p=398b5bde334a80d691a1d1e15fdfd12e&pm=s
What I've implemented is a Base ChargedAttack class that has the logic for slowing down the character when using the attack and the logic to stun an enemy when the attack is max charged.
After the changes, LyrielChargedAttack and DeathChargedAttack no longer inherit from LyrielAbilityBase and DeathAbilityBase respectivly, instead they inherit fomr they new base class and all the logic needed to cover these two new features has been added.
The new configuration for the Charged Attack can still be found in Lyriel and Death Config classes, with a option to enable or disable the charged attack stun and tweak the stun dduration and the movement slowdown percentage.
The changes can be tested in the scene called "ChargedAttackChanges". As always, I let you see a video or it also here:
https://youtu.be/D3KDdci4IMo
PD: I have some future changes regarding the UI and the Sound of the ChargedAttack but they cannot be implemented yet and we don't have the necessary sprites and sounds but I share the notes with you.