Enemies HP#123
Open
JorxPi wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes the following task: https://app.notion.com/p/32cb5bde334a80088f14c3797dfff605?v=35db5bde334a807ab4fd000c0ea45edd&p=398b5bde334a80f984f0d6b3101902cd&pm=s
On top of adding the necessary code in EnemyDamageable to hide the HP bar until they recieve any amount of damage, I made some small changes/cleanups in Damageable base class, which was including some References that were only needed for the players, so I moved those to PlayerDamageable class to keep everything clean.
Finally I changed all the enemy prefabs reducing the size of their HP bar up to 50% and the size of the shadow mark up to 70% (modifiying a little bit also how much they were moving above the enemies head when apearing).
In the scene called "EnemiesHpTest" you can see in the first room all the enemies and see how the new changes behave and teir new hp bar and shadowmark size.
https://youtu.be/PSL7039b2Bg