Use /bin/sh to launch editor (proper shell quoting for editor)#265
Open
JacksonChen666 wants to merge 2 commits into
Open
Use /bin/sh to launch editor (proper shell quoting for editor)#265JacksonChen666 wants to merge 2 commits into
JacksonChen666 wants to merge 2 commits into
Conversation
RasmusLindroth#96 Co-authored-by: Jez Cope <j.cope@erambler.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That was my somewhat ranty rant. This PR is pretty much this but rebased so that it works on the master branch.
Also, I tested it, now my thing works. I'm not sure of other scenarios where it doesn't work (or works against the user).
(Questions welcome, although you should read the quoted text for rationale. I am sending this in quite a hurry because I already lost a previous version of my comment, it's nearly midnight and i'm kinda annoyed, so let me know of any little imperfections)