typescript sdk#2853
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny: 10-day-old account with no public repositories, mitigated by repository write permission, matching commit authorship, and no known Gittensor association; bittensor-core-typescript-sdk → bittensor-core-exploration. No protected AI-review or Copilot instruction files were modified. Static review found no malicious behavior or security vulnerability in the SDK, native key-handling boundaries, locked dependencies, build scripts, or fork-gated CI execution. FindingsNo findings. ConclusionThe prior wasm-pack supply-chain concern remains resolved, and the current diff introduces no new security findings. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN; very new contributor with repository write access, so this large SDK addition received heightened correctness scrutiny. Description discrepancyThe implementation was renamed, but the PR body still references No spec-version bump applies to this non-network base branch. The overlapping PRs are complementary rather than duplicates. FindingsNo findings. ConclusionThe latest compatibility additions preserve the existing typed APIs and have focused coverage. Only the non-blocking stale paths in the PR description remain. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
Add a first-party TypeScript SDK backed by the shared Rust
bittensor-coreimplementation. This avoids reimplementing key handling, SCALE/runtime operations, timelock cryptography, metadata digests, Ledger support, and MEV-shield primitives in JavaScript.Changes
sdk/typescript-sdk, including CommonJS and ESM entry points and TypeScript declarations.bittensor-corefor keys, runtime metadata and SCALE operations, signed extrinsics, timelock operations, ML-KEM, metadata digests, and Ledger support.Files of interest
sdk/typescript-sdk/native/— Node-API binding layersdk/typescript-sdk/src/— TypeScript API and compatibility adapterssdk/typescript-sdk/test/basic.test.cjs— package-level teststs-tests/suites/dev/sdk/test-typescript-sdk.ts— chain integration test.github/workflows/typescript-e2e.yml— SDK build and e2e integrationBehavioral impact
TypeScript consumers can use the shared Rust implementation through
@bittensor/sdk. Existing e2e helpers now create and use Rust-backed keypairs. This PR does not change on-chain runtime behavior.Migration and spec version
No storage migration is required. No runtime spec-version bump is required because the runtime is unchanged and the target branch has no network spec-version check.
Testing
CI builds and type-checks the SDK, runs its package tests, and submits a signed transaction through the dev-chain e2e suite.