fix(storage): bound AutoMigrate with configurable deadline#65
Merged
Conversation
Without a timeout, db.AutoMigrate inherits no deadline. On Postgres under load, an ALTER TABLE waits indefinitely for a relation lock — hanging the entire binary startup with no log output and requiring kill -9 to recover. Adds DB_MIGRATE_TIMEOUT_SECS (default 60s, max 1h, set 0 to opt out) and threads it through MigrateOptions.Timeout into a context applied to the AutoMigrate call only via db.WithContext. Pre/post hooks (FTS5 setup, legacy index drops) remain unbounded since they don't take long-held locks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR C of 6. Closes the startup-hang gap: `db.AutoMigrate` had no deadline, so a Postgres relation-lock wait blocked startup indefinitely with no log output.
Test plan
🤖 Generated with Claude Code