feat(telemetry): add per-signal ingest E2E latency histogram#63
Merged
Conversation
Closes the production-readiness gap where there was no way to set or
alert on a p99 ingest SLO — IngestionRate was a counter only, and
GRPCRequestDuration covered the gRPC layer broadly without a per-signal
split.
Adds otelcontext_ingest_duration_seconds{signal} histogram observed via
defer time.Since(start) in TraceServer/LogsServer/MetricsServer.Export.
The HTTP OTLP handler delegates to the same Export methods so both
transports record uniformly with a single instrumentation site.
- New label "signal" ∈ {traces, logs, metrics} for per-signal SLO alerting
- Buckets cover 1ms..10s (typical OTLP ingest range)
- Nil-safe ObserveIngestDuration helper protects ingest tests that pass
nil telemetry.Metrics
- Subtests in metrics_pool_test.go assert per-label count advances and
nil-receiver safety
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR A of 6 from the production-readiness brainstorm. Closes the SLO blind spot identified by codex round 1 — there was no way to alert on a p99 ingest SLO because IngestionRate is a counter and GRPCRequestDuration aggregated all gRPC methods.
Test plan
🤖 Generated with Claude Code