Post-robustness follow-ups#25
Merged
Merged
Conversation
- .gitignore: exclude build artifacts (/bin, /loadsim, /otelcontext) - graphrag: canonicalize investigation cooldown key (lower + trim) so "Orders" / "orders " / "ORDERS" share a bucket; otherwise trivial casing differences would bypass the cooldown guard - graphrag: consolidate time.Now() calls in PersistInvestigation to a single now := time.Now() at the top - graphrag/refresh.go: spell out the cooldown-prune cutoff's dependency on RefreshEvery to keep future tuning honest - storage: delete dead verifyP99Index helper and math import in metrics_p99_test.go Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small hygiene pass picking up the deferred follow-ups from PR #24.
.gitignore: exclude/bin,/loadsim,/otelcontextbuild artifacts(trigger_service, root_service, root_operation)withstrings.ToLower+TrimSpacebefore hashing — without it,"Orders"and"orders "were bypassing the 5-minute guardtime.Now()calls inPersistInvestigationto onenow := time.Now()at the topRefreshEvery ≤ 10m— raising one without the other would re-introduce the bypassverifyP99Indexhelper + now-unusedmathimportTest plan
go build ./...cleango vet ./...cleanCGO_ENABLED=1 go test -race -timeout 180s ./...— 10/10 packages passTestCooldownKey_Canonicalcovers case/whitespace variantsNot addressed here
StartRuntimeMetricsgoroutine stop channel — pre-existing; deferredsqliteP99RowCapasatomic.Int64— hypothetical race not triggered by current tests.env.example— tracked separately🤖 Generated with Claude Code