Skip to content

fix: skip binary detection for PDF and DOCX files #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aksOps merged 1 commit into from
Mar 20, 2026
Merged

fix: skip binary detection for PDF and DOCX files #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions internal/loader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,30 @@ func init() {
}
}

// knownBinaryFormats are file extensions for formats that are inherently binary
// but have dedicated loaders that know how to parse them.
var knownBinaryFormats = map[string]bool{
".pdf": true,
".docx": true,
}

// Load dispatches to the correct loader by file extension.
// Returns ErrBinaryFile (non-fatal) if the file looks like a binary.
func Load(path string) (*RawDocument, error) {
binary, err := isBinary(path)
if err != nil {
return nil, err
}
if binary {
return nil, fmt.Errorf("%w: %s", ErrBinaryFile, path)
ext := strings.ToLower(filepath.Ext(path))

// Skip binary detection for formats that are inherently binary but have
// dedicated parsers (PDF, DOCX).
if !knownBinaryFormats[ext] {
binary, err := isBinary(path)
if err != nil {
return nil, err
}
if binary {
return nil, fmt.Errorf("%w: %s", ErrBinaryFile, path)
}
}

ext := strings.ToLower(filepath.Ext(path))
for _, l := range registry {
if l.Supports(ext) {
return l.Load(path)
Expand Down
Loading