feat(agent): add hermes agent support#25
Merged
Merged
Conversation
Registers hermes under agent.Registry with the canonical name 'hermes'. BuildCommand and DiscoverSessionID are stubbed; real implementations land in the next two commits.
Hermes' resume API differs from codex: --resume <id> (flag), -c for most-recent, --yolo as the bypass flag. Pattern otherwise mirrors codex including the '|| hermes' fallback for crash recovery on resume.
Shells out to the hermes CLI and regex-extracts the session ID instead of linking a SQLite driver (which the codex pivot intentionally removed). 5s budget, 250ms poll. Tests use a bash shim wired in via CTM_HERMES_BIN to drive the subprocess deterministically.
Replaces hardcoded []string{"tmux","codex","git"} in both
cmd/doctor.go and internal/doctor/doctor.go with a registry walk:
{tmux} + agent.Registered() + {git}. Future agents are picked up
automatically without touching doctor.
Also blank-imports internal/agent/hermes from main.go so the ctm
binary actually registers the hermes agent at startup (codex was
already blank-imported); without it the registry walk would not
surface hermes in `ctm doctor`.
README gains a 'Multi-agent' feature bullet pointing at --agent hermes. CHANGELOG [Unreleased] gets a new Added section describing the agent package, resume semantics, discovery strategy, and the doctor refactor.
|
7 tasks
aksOps
added a commit
that referenced
this pull request
May 16, 2026
* feat(cmd): add --agent flag to new/yolo/yolo!/safe Wires `--agent <name>` through cmd/new.go and cmd/yolo_runners.go into createAndAttach -> SpawnOpts.Agent. Empty value falls through to session.DefaultAgent; unknown agents fail fast with a list of registered names so users can correct the flag. Closes the gap shipped (claimed but not delivered) in #25: README and CHANGELOG both promised `ctm new --agent codex` and `ctm new --agent hermes` but the cobra flag was never wired. The Agent registry, hermes package, and SpawnOpts.Agent field were already in place — this PR is purely the CLI surface. Tests cover empty / registered / unknown agent cases via the new resolveAgent helper. Suite count goes 410 -> 413. * refactor(cmd): extract addAgentFlag + agentFromCmd helpers to dedupe Sonar's duplication gate (10.3% > 3% on new code) flagged the 4x repeated 'flag().String("agent", ...)' + 4x 'GetString + resolveAgent + err handling' blocks across new/yolo/yolo!/safe RunE bodies. Extracted addAgentFlag (registers the flag) and agentFromCmd (reads + validates) into cmd/yolo.go. Each call site is now a single helper call. resolveAgent stays separate so the unit tests in yolo_helpers_test.go still exercise the validation logic without needing a cobra.Command in scope. * test(cmd): cover addAgentFlag + agentFromCmd helpers Sonar's coverage gate (77.8% < 80%) flagged the two thin wrappers added by the dedup refactor. Adds direct unit tests: - TestAddAgentFlag: registers + default value + usage text - TestAgentFromCmd_FlagUnset / _FlagSetValid / _FlagSetInvalid: read + validate flow on a fresh cobra.Command Helpers now at 100% coverage. Suite count goes 413 -> 417.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
hermesas a second registered agent alongsidecodexso users canctm new --agent hermes/ctm yolo --agent hermeswith full lifecycle parity (spawn → discover session id → resume → process-liveness).internal/agent/hermes/mirrorsinternal/agent/codex/shapehermes --resume <id>(flag, not positional like codex);-cfor most-recent--yolo(single flag)DiscoverSessionIDshells out tohermes sessions list --source cliand regex-extracts the ID — avoids re-introducing the SQLite Go driver that the codex pivot deliberately removed[]string{"tmux","codex","git"}→{tmux} + agent.Registered() + {git}in bothcmd/doctor.goandinternal/doctor/doctor.go. Future agents N+1 picked up automaticallymain.goblank-imports the new package alongside codexinternal/agent/hermes/process.go— codex's copy is legacy dead-weight;internal/procscanis the canonical seam viaAgent.ProcessName()Files changed
internal/agent/hermes/{hermes,command,discover}.go+ 3 test files +testdata/fake-hermes.shcmd/doctor.go,internal/doctor/doctor.go,internal/doctor/doctor_test.gomain.goREADME.md,CHANGELOG.md6 commits, all atomic + independently green:
49bbf04scaffold hermes agent package989cbcbBuildCommand for fresh/resume/yolo branches4dd284dDiscoverSessionID via 'hermes sessions list'85f0981refactor doctor dep list to agent.Registered()dac2a3ddocs README + CHANGELOG0a8…gofmt style fixTest plan
go test ./...— 410 tests across 20 packagesgo test -race ./...— cleango vet ./...— cleangofmt -dclean on all touched files (pre-existing drift in untouched files left alone per scope discipline)ctm doctorlists hermes alongside tmux/codex/gitctm new --agent hermes) — deferred to reviewer; spawns real tmux + hermesRisks / notes
hermes sessions listtable format drift would break the discovery regex; we anchor on the ID structure (\d{8}_\d{6}_[0-9a-fA-F]{6,}$), not column positions, so this survives column reorders.hermes -c(degraded but correct).+dirtypseudo-version bug is pre-existing and orthogonal; not addressed here.🤖 Generated with Claude Code