fix: EnrichCommand passes project root to ServiceDetector for filesystem walk#9
Merged
Merged
Conversation
…ing enrich EnrichCommand called the 3-arg overload of ServiceDetector.detect(), which set projectRoot=null and skipped the filesystem walk entirely. Multi-module projects (e.g. .NET eShop with 20+ .csproj files) only received the single root-fallback SERVICE node because their build files were never parsed into CodeNodes by any detector. Passing `root` as the 4th argument enables the filesystem scan, so all modules are discovered regardless of whether a detector created a node for their build file. Added ServiceDetectorTest#filesystemWalkFindsModulesNotPresentAsNodes to verify this path with a simulated .NET monorepo (3 .csproj files, no matching CodeNodes). Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnrichCommand.java:148called the 3-arg overload ofServiceDetector.detect(), passingprojectRoot=nulland skipping the filesystem walk entirely..csproj,pom.xml,build.gradle, etc.) are not parsed into CodeNodes got only 1 SERVICE node (root fallback). Confirmed broken on eShop (.NET) with 20+.csprojfiles.rootas the 4th argument so the filesystem walk runs and all modules are discovered regardless of detector coverage.filesystemWalkFindsModulesNotPresentAsNodes— simulates a .NET monorepo with 3.csprojfiles and no matching CodeNodes; asserts all 3 services are detected.Test plan
ServiceDetectorTest— 29 tests, 0 failuresCloses RAN-49
🤖 Generated with Claude Code