phase a/fix np null#44
Merged
Merged
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThis PR establishes a comprehensive baseline infrastructure for quality assurance and testing. It adds a suite of Bash scripts to capture toolchain versions, execute quality checks (Maven tests with JaCoCo coverage, SpotBugs analysis, OWASP dependency scanning, flaky test detection, and frontend E2E tests), manage seed repositories, and consolidate results into a centralized baseline report. Additionally, it hardens the Java codebase against null pointer exceptions by replacing direct Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
… findings
All 26 SpotBugs NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE findings shared
the same shape: calling `.toString()` on `Path.getFileName()` (or once
on `Path.getParent()`) where the result can legitimately be null for
root-like paths (e.g. `/`, a bare filename with no parent).
Uniform fix: wrap every `path.getFileName().toString()` with
`java.util.Objects.toString(path.getFileName(), fallback)`, choosing a
sensible per-site fallback:
- `""` where the string is then substring-matched against a known
set (filenames, extensions, excluded-dir names); empty never
matches those sets, preserving existing semantics.
- `"unknown"` for human-facing project names in TopologyCommand,
EnrichCommand service detection, StatsCommand output header.
- `"bundle"` for BundleCommand's project-name derivation.
- `"flow"` for FlowCommand's html project name.
- `PROP_ROOT` (existing constant) in Analyzer.
One non-`getFileName` case: AnalysisCache's constructor called
`Files.createDirectories(dbPath.getParent())` unconditionally; rewrote
as a null-guarded block so a bare-filename dbPath (no directory
component) doesn't NPE.
Files touched (12):
analyzer/Analyzer.java (5 edits — incl. 1 replace_all
that covered 3 triplicated blocks
in analyzeFileWithRegistry /
analyzeFile / createInventoryNode)
analyzer/ConfigScanner.java (1)
analyzer/FileClassifier.java (1)
analyzer/FileDiscovery.java (2)
analyzer/ServiceDetector.java (3)
cache/AnalysisCache.java (1 — getParent null-guard)
cli/BundleCommand.java (1)
cli/EnrichCommand.java (2)
cli/FlowCommand.java (1)
cli/PluginsCommand.java (2)
cli/StatsCommand.java (1)
cli/TopologyCommand.java (1)
Verified:
- `mvn compile` clean.
- `mvn spotbugs:spotbugs` re-run: NP_NULL count 26 -> 0.
- `mvn test` (full suite): 3,059 tests, 0 failures, 0 errors.
No behavior change for the common case: for any non-root path,
`path.getFileName() != null` and Objects.toString returns the same
value as the old `.toString()`. The fallback string is only observed
if callers hand in a root-like path — previously an NPE, now a safe
sentinel that flows through existing logic.
aksOps
force-pushed
the
phase-a/fix-np-null
branch
from
c23e69d to
a8ef6b6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores