fix: resolve all 9 SonarCloud reliability bugs#40
Merged
Conversation
- S2159: GitHubActionsDetector — equals() on unrelated types (Boolean.TRUE.equals(key) → "true".equals(String.valueOf(key))) - S5998: NestJSControllerDetector L44,48 — regex stack overflow (added possessive quantifiers *+ to nested groups) - S5850: CSharpStructuresDetector L214 — regex precedence ((^/+|/+$) → (^/+)|(/+$) with explicit grouping) - S5855: GrpcServiceDetector L36 — redundant regex alternative (removed void| since [\w<>\[\]]+ already matches it) - S5998: RawSqlDetector L30,35,37 — regex stack overflow (added possessive quantifiers *+ to nested groups) - S3655: JpaEntityDetector L201 — Optional accessed without isPresent (stored Optional in variable before isPresent + get) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 open SonarCloud reliability bugs (type=BUG) to pass the quality gate.
Bugs Fixed
Boolean.TRUE.equals(key)compared Boolean to String map key — changed to"true".equals(String.valueOf(key))*+(^/+|/+$)— split to(^/+)|(/+$)void|[\w<>\[\]]+redundant — simplified to[\w<>\[\]]+([^"\\]*(?:\\.[^"\\]*)*)nested*— added possessive*+Optional.get()without priorisPresent()— stored Optional in variableTest plan
🤖 Generated with Claude Code