refactor: reduce code duplication from 11.5% to ~6-7%#38
Merged
Conversation
…ctWithRegex duplication Python auth/route detectors: - FastAPIAuthDetector: 5 helpers (createDependsGuard, createSecurityGuard, etc.) - DjangoAuthDetector: 4 helpers (createLoginRequiredGuard, etc.) - FastAPIRouteDetector: createRouteEndpoint helper - DjangoViewDetector: createUrlPatternEndpoint, createCbvNode helpers - FlaskRouteDetector: createFlaskRouteEndpoint, createExposesEdge helpers - CeleryTaskDetector: createQueueNode, createMethodNode, edge helpers Python entity detectors: - DjangoModelDetector: 7 helpers (createModelNode, extractMeta, addFkEdges, etc.) - SQLAlchemyModelDetector: 4 helpers (createEntityNode, extractColumns, etc.) - PydanticModelDetector: 5 helpers (createPydanticNode, extractConfigProps, etc.) - PythonStructuresDetector: 8 helpers + AllExports record Frontend detectors: - FrontendDetectorHelper: createComponentNode, lineAt shared helpers - Refactored Angular, React, Vue component detectors Java messaging detectors: - AbstractJavaMessagingDetector: CLASS_RE, extractClassName, addMessagingEdge - Refactored JMS, IBM MQ, Tibco EMS, RabbitMQ detectors Scala/Kotlin structures: - StructuresDetectorHelper: addImportEdge, createStructureNode, edge helpers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates ~530 lines of duplicated code across 22 files by extracting shared helper methods. The main pattern was
detectWithAst()anddetectWithRegex()duplicating identical node-creation code within each detector.Changes
Python detectors (10 files, ~500 lines removed)
Frontend detectors (3 files)
FrontendDetectorHelperwithcreateComponentNode()andlineAt()— shared by Angular, React, Vue detectorsJava messaging detectors (4 files)
AbstractJavaMessagingDetectorwithCLASS_RE,extractClassName(),addMessagingEdge()— shared by JMS, IBM MQ, Tibco EMS, RabbitMQScala/Kotlin structures (2 files)
StructuresDetectorHelperwithaddImportEdge(),createStructureNode(), edge helpersTest plan
🤖 Generated with Claude Code