feat(web): React UI v2.0 — Phase 4 Task 42 (SessionCanvas) — Phase 4 complete#29
Merged
Merged
Conversation
Composes CanvasHead + Transcript over useSessionFull(sid). Handles
null sid (empty state), loading, error+retry, and not-found cases.
App.tsx now renders <SessionCanvas activeSid={activeSid} /> in place
of the empty-state placeholder. The double useSessionFull subscription
(App for Statusbar counters, SessionCanvas internally) is acceptable
v1 tech debt — Phase 6+ refactor when needed.
Test helper render() now wraps with SelectedRefProvider so component
tests using useSetSelected (via SessionCanvas → onSelectTool) work
without per-test wrappers; matches production layout in main.tsx.
Stop/Approve/Reject callbacks are no-ops (// Phase 6).
Tests: 125 passing (+5).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composes CanvasHead + Transcript with useSessionFull(activeSid). Empty state when null, loading state, error envelope with Retry. Wires into App.tsx replacing the placeholder canvas pane. First real session render.
Also updates the shared test render() helper to wrap with SelectedRefProvider (matches production main.tsx) so any test using selectedRef context works without per-test wrappers.
Known tech debt: App.tsx and SessionCanvas both call useSessionFull(activeSid) — wasteful double subscription. Refactor in Phase 6+ when modals/intents need centralized session state.
125 tests pass (120 + 5). Phase 4 complete.
🤖 Generated with Claude Code