feat(web): React UI v2.0 — Phase 3 Tasks 32-35 (Shell components)#24
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Phase 3 Batch A of React UI v2.0 — the four visual shell components. Task 36 (App wiring) follows in a separate PR.
<Topbar>(web/src/shell/Topbar.tsx, 48 px) — brand mark + name + breadcrumb (app/env) + health pill + search box + approvals badge (amber, only when count>0) + New Session button + user identity. Props-driven; emits onSearch/onNew/onApprovalsClick intents. 7 tests.<Statusbar>(web/src/shell/Statusbar.tsx, 24 px) — connection state dot + SSE event counter + vm_seq (color-coded by state: in-sync/replaying/divergent) + optional p95 latency + runtime/ui versions. 3 tests.<SessionsRail>(web/src/shell/SessionsRail.tsx, 220 px) — sessions list with Active/Recent grouping (status-based), filter input, accent left-rail for active row, amber pending dot for awaiting_input sessions, empty state, onSelect callback. 8 tests.<FlowStrip>(web/src/shell/FlowStrip.tsx, 92 px) — the signature visual. Inline SVG agent graph with horizontal layout, breathing halo CSS animation on the active node (4 s ease-in-out), status-driven colors (idle / active / done / gated / error). Particles deferred to v2.1; v1 hero treatment is the halo. Respectsprefers-reduced-motion. 5 tests.Validation
cd web && npm install→ 0 vulnerabilitiesnpm run typecheck→ exit 0npx vitest run→ 87 passed / 0 failed (Phase 2's 64 + 23 new)npm run build→ clean, 10 kB CSS (added halo + modal keyframes), 194 kB JSNothing touches
src/runtime/— nodist/app.pyregen.Design notes
useUiHints,useApprovalsQueue,useSessionList,useAgentDefinitions,useSessionFull) get composed and their results passed down. This keeps each component unit-testable without QueryClient/Context plumbing.<Topbar>onClick={onSearch}originally fired twice (bubbling from inner input). Fixed by wiring the click on the outer wrapper only — bubbling from the readonly input still reaches it. Documented in commit + reviewer notes.<FlowStrip>v1 lays out agents in declaration order with cubic-bezier edges between neighbors. Topology-aware layout honoringroutesis a v2.1 enhancement once the spec hardens.<SessionsRail>rows uses status === 'awaiting_input' as the v1 signal (no per-session approval-count fetch). Refined in v2.1 if needed.Test plan
🤖 Generated with Claude Code