feat(web): React UI v2.0 — Phase 1 Tasks 16-20 (5 component primitives)#19
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Phase 1 Batch B of React UI v2.0 — five component primitives, dispatched in parallel via subagent-driven-development. Completes Phase 1 of the React UI v2.0 plan (modulo the deferred ESLint config, see Out of Scope).
<Icon>+ inline SVG sprite (13 icons: check, x, plus, stop, retry, search, alert, info, arrow-right, back, list, network, message).currentColorinheritance, 12/14/16 px sizes.<Button>withprimary/secondary/ghostvariants +smsize. CSS-var-driven styling, sharp corners, ink-on-bg primary.<Pill>(status: running/paused/error/resolved/neutral) +<Tag>(metadata: default/mono). SHORT_CAPS pill labels viatext-transform: uppercase.<Input>,<Textarea>,<Select>form primitives. Shared 28 px height (22 sm),var(--hair)border,var(--acc-soft)1 px focus-ring.<Select>uses native<select>since@radix-ui/react-selectisn't in deps — Radix Select can be swapped in later as a non-breaking enhancement.<Modal>(Radix Dialog wrapper). Centered, 480-720 px width, 52 px header / scrollable body / optional preview band / 52 px footer. 180 ms scale 0.96→1 + fade in, 140 ms exit. Esc dismisses (browser standard).prefers-reduced-motionshort-circuits to 0.01 ms.Validation
cd web && npm install→ 0 vulnerabilitiesnpm run typecheck→ exit 0npx vitest run→ 30 passed / 0 failed (Icon 2 · Button 5 · Pill 7 · Tag 3 · Input 4 · Textarea 2 · Select 2 · Modal 4 · smoke 1)npm run build→ clean, 8.05 kB CSS, 194 kB JSNothing touches
src/runtime/— nodist/app.pyregen needed.Out of scope (deferred to Task 20b)
ESLint config (
web/eslint.config.ts) — requires adding@eslint/js,typescript-eslint,eslint-plugin-react-hooksdevDependencies which were not inpackage.json. Will land alongside the Phase 8 build/deploy/CI work where dep additions are batched.@radix-ui/react-selectupgrade for<Select>— current native<select>works fine; Radix swap is a separate task if needed for styling parity.Test plan
🤖 Generated with Claude Code