feat(web): React UI v2.0 — Phase 1 Tasks 13-15 (fonts + TS tokens + Vitest)#18
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Phase 1 Batch A of React UI v2.0 implementation — three independent foundation pieces, dispatched in parallel via subagent-driven-development.
.woff2files, OFL-1.1 NOTICE) so the@font-facedeclarations from Task 12 actually resolve at build time. Eliminates the 5 font-404 warnings noted as expected interim state in PR feat: React UI v2.0 — Phase 0 backend foundation + Phase 1 scaffold start #17.web/src/tokens/{colors,typography,spacing,elevation,index}.ts) mirroringtokens.css. Lets future component code reference tokens type-safely from JS (inline animations, computed values).vitest.config.ts,tests/setup.ts,tests/_helpers/render.tsx,tests/unit/smoke.test.ts).renderhelper wraps in freshQueryClientProviderper call (retry:false, gcTime:0).Validation
cd web && npm install→ 0 vulnerabilitiesnpm run typecheck→ exit 0npm run test:unit→ 1 passednpm run build→ clean, no font-404 warnings, fonts ship indist/fonts/Nothing touches
src/runtime/— nodist/app.pyregen needed.Drift notes
tokens.css--ff-sansincludes-apple-system, system-ui(extra fallback for pre-2017 Safari); the TStypography.tsmatches the spec verbatim (system-uionly). Both are correct for their medium — no reconciliation needed. Spec reviewer signed off.Test plan
npm run typecheckpassesnpm run test:unitsmoke test passesnpm run buildproduces clean output with vendored fontsOut of scope
Phase 1 Tasks 16-20 (
<Icon>,<Button>,<Pill>+<Tag>,<Input>+<Textarea>+<Select>,<Modal>+ESLint) — the 5 component primitives — are the next batch and will ship in a follow-up PR.🤖 Generated with Claude Code