fix(xlsx): preserve sheet-scoped defined names - #14
Merged
RainLib merged 1 commit intoJul 21, 2026
Merged
Conversation
Owner
Author
|
Independent branch validation completed because this stacked PR targets a feature branch and the pull_request workflow only listens to main. GitHub Actions run https://github.com/RainLib/OfficeCli-rust/actions/runs/29791933567 passed: format, clippy, workspace tests, and all 7 release build targets (including native smoke tests where applicable). The only annotations are the repository-wide actions/cache@v4 Node.js 20 deprecation notices. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
definedName@localSheetIdwhen inserting a worksheet at a logical position.XLSX-001.Why
Sheet insert, move, and remove operations could leave defined names bound to the wrong worksheet or leave dangling package references.
Validation
cargo fmt -- --checkcargo clippy --all-targets -- -D warningscargo test --workspaceReview stack
This PR targets
feature/pptx-slide-removal-parityso its diff contains only the XLSX atomic change. Retarget it tomainafter the PPTX base PR merges.