Skip to content

fix(pptx): preserve package identity when removing slides - #13

Merged
RainLib merged 1 commit into
mainfrom
feature/pptx-slide-removal-parity
Jul 21, 2026
Merged

fix(pptx): preserve package identity when removing slides#13
RainLib merged 1 commit into
mainfrom
feature/pptx-slide-removal-parity

Conversation

@RainLib

@RainLib RainLib commented Jul 21, 2026

Copy link
Copy Markdown
Owner

What changed

  • Resolve logical slide indexes through presentation relationships instead of assuming slideN.xml.
  • Remove the slide ID, presentation relationship, slide part, slide rels, content type override, and dangling custom-show references.
  • Allocate unused slide part, slide ID, and relationship ID when adding after a middle-page deletion.
  • Record the C# parity baseline and migration ledger under docs/csharp-parity.

Why

Deleting a middle slide could leave dangling package references, and later operations could edit or overwrite the wrong physical slide part.

Validation

  • cargo fmt -- --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test --workspace
  • Package-level custom-show cleanup tests
  • CLI smoke: create → add → remove middle → edit logical slide → add → validate

@RainLib
RainLib merged commit e8735d3 into main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant