fix: make PDF HTML output self-contained - #11
Merged
Conversation
RainLib
force-pushed
the
agent/fix-pdf-standalone-html
branch
from
July 20, 2026 08:05
8b2514f to
c7901d7
Compare
RainLib
force-pushed
the
agent/fix-pdf-standalone-html
branch
from
July 20, 2026 08:10
c7901d7 to
36d65af
Compare
RainLib
marked this pull request as ready for review
July 20, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The CLI and watch server shared the same lazy-loading HTML path. As a result,
officecli view <file.pdf> --mode htmlemittedfetch(page/{n}/html)requests that only work while the watch server is running.Impact
HTML generated from a PDF can now be saved and opened independently without an OfficeCLI server. Large watch previews retain their existing lazy-loading behavior.
Validation
/page[1]and contained nofetch.cargo test -p pdf-handler --offline(11/11 passed)cargo clippy --all-targets --offline -- -D warningscargo test --workspace --offline(including 54 CLI smoke tests)Fixes #3