fix: handle Unicode safely in XLSX text view - #10
Merged
Conversation
RainLib
force-pushed
the
agent/fix-xlsx-unicode-truncation
branch
from
July 20, 2026 08:05
fa8f4e7 to
888b948
Compare
RainLib
marked this pull request as ready for review
July 20, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
chars()without slicing through a code point.Root cause
The text-grid renderer used
String::len()and byte-range slicing. When the truncation boundary landed inside a multibyte character, Rust panicked withis not a char boundary.Impact
officecli view <file.xlsx> --mode textnow safely renders and truncates CJK and other multibyte text.Validation
cargo test -p xlsx-handler --offline(25/25 passed)cargo clippy --all-targets --offline -- -D warningscargo test --workspace --offline(including 54 CLI smoke tests)Fixes #4