irqchip/sifive-plic: fix stuck in-progress IRQ on affinity migration#247
Open
swjtuer326 wants to merge 1 commit into
Open
irqchip/sifive-plic: fix stuck in-progress IRQ on affinity migration#247swjtuer326 wants to merge 1 commit into
swjtuer326 wants to merge 1 commit into
Conversation
|
开始测试 log: https://github.com/RVCK-Project/rvck-olk/actions/runs/29484887421 参数解析结果
测试完成 详细结果:
Kunit Test Result[08:55:41] Testing complete. Ran 482 tests: passed: 466, skipped: 16
Kernel Build Result
Check Patch Result
LAVA Check (qemu)
result: Lava check done!
|
community inclusion category: bugfix bugzilla: RVCK-Project#246 Reference: RVCK-Project#247 -------------------------------- The PLIC silently drops a completion whose source is not enabled for the target hart, and until it receives a completion it will not re-deliver the source, so the device stops receiving interrupts. During affinity migration plic_set_affinity() clears the old hart's enable bit; if that lands between claim and completion, the completion is dropped. For a direct PLIC IRQ, plic_irq_eoi() and plic_set_affinity() are both under desc->lock and cannot race, but a PLIC IRQ backing a chained irqchip issues the completion from chained_irq_exit() and reaches plic_set_affinity() via the chained chip's ->irq_set_affinity() callback, neither holding desc->lock. Take the per-context enable_lock (already held by plic_toggle() when clearing the enable bit) across plic_irq_eoi() so the affinity clear cannot overlap the EOI; test the enable bit inside the critical section and re-enable around the completion if it is clear. enable_lock nests inside desc->lock, so no new lock ordering is introduced. Signed-off-by: Bowen Pang <bowen.pang01@sophgo.com>
swjtuer326
force-pushed
the
plic-affinity-fix
branch
from
July 16, 2026 08:52
d4062ef to
885537f
Compare
|
开始测试 log: https://github.com/RVCK-Project/rvck-olk/actions/runs/29485015232 参数解析结果
测试完成 详细结果:
Kunit Test Result[08:57:06] Testing complete. Ran 482 tests: passed: 466, skipped: 16
Kernel Build Result
Check Patch Result
LAVA Check (qemu)
result: Lava check done!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
community inclusion
category: bugfix
bugzilla: #246