[WIP][ROCm] Drop support for ROCm < 7.0#863
Open
nurmukhametov wants to merge 5 commits into
Open
Conversation
nurmukhametov
added
the
claude-review
Claude Code Review — ROCm < 7.0 Support RemovalLGTM — Clean, well-structured cleanup. Verified across all 17 changed files:
No issues found. |
github-actions
Bot
removed
the
claude-review
nurmukhametov
force-pushed
the
anurmukh/remove-old-rocm-support
branch
from
ee3064c to
a745420
Compare
i-chaochen
approved these changes
May 19, 2026
| raise ConfigError( | ||
| "{} version file not found in {}".format(component_name, candidates)) | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Thanks for this refacotring!
nurmukhametov
force-pushed
the
anurmukh/remove-old-rocm-support
branch
2 times, most recently
from
38b3791 to
b768e0e
Compare
… prevent crash risk with AVX/SIMD instructions. PiperOrigin-RevId: 921447706
PiperOrigin-RevId: 921452881
PiperOrigin-RevId: 921453001
Reject ROCm older than 7.1 at configure and compile time, and remove all version-gated fallback code for older releases. - find_rocm_config.py: raise ConfigError when composite version < 70100 - rocm_config.h.tpl: emit #error when TF_ROCM_VERSION < 70100 - Strip dead #if TF_ROCM_VERSION >= X guards - Drop ROCm <= 5.1 header path fallbacks find_rocm_config.py - Refactor the per-component version-file lookup into a shared _find_version_file() helper in find_rocm_config.py
nurmukhametov
force-pushed
the
anurmukh/remove-old-rocm-support
branch
from
b768e0e to
4ccd307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[Do not merge] For review only.
Technical Details
Reject ROCm older than 7.0 at configure and compile time, and remove all version-gated fallback code for older releases.
Submission Checklist