Reduce iota_test execution time: shared pjrt client + automatic shard number#851
Closed
mfrancepillois wants to merge 2 commits into
Closed
Reduce iota_test execution time: shared pjrt client + automatic shard number#851mfrancepillois wants to merge 2 commits into
mfrancepillois wants to merge 2 commits into
Conversation
7218753 to
e602e57
Compare
i-chaochen
reviewed
May 10, 2026
Collaborator
i-chaochen
left a comment
There was a problem hiding this comment.
this PR should be against to the main branch instead of 0.9.2, isn't?
Author
Another PR has been open against the main rocm branch: #852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The iota_test was very slow on AMD targets (compared to NVDIA) for 2 main reasons:
iota_test. This task in ROCm, which callshipCtxDestroy() + hipCtxCreate(), was ~40× slower than with CUDA (see table below). => We therefore modified the code to create only 1 pjrt client per process and share it among the tests within that process.This PR re-enables iota_test in AMD CIs