Add docker image to use hermetic llvm and sysroot#782
Conversation
hsharsha
force-pushed
the
hhs/add_docker_for_jax_xla
branch
from
5ab7632 to
80c6d34
Compare
hsharsha
requested review from
JehandadKhan,
alekstheod,
charleshofer,
i-chaochen,
leo-automation,
mminutoli and
tsrw2048
|
@mminutoli should we keep docker files here now that rocm-jax would be depricated. Or do we still want to keep all the infra related files there? |
| run: | | ||
| working-directory: ./build/rocm/docker/ |
There was a problem hiding this comment.
Probably a typo, it needs to be its own line. As it is now, the script will fail
| # - jammy | ||
| # - el7 | ||
| # - el8 | ||
| set -x |
There was a problem hiding this comment.
| set -x | |
| set -euo pipefail | |
| set -x |
|
|
||
| jobs: | ||
| build-docker: | ||
| runs-on: ${{ fromJSON(inputs.runner-label) }} |
There was a problem hiding this comment.
| runs-on: ${{ fromJSON(inputs.runner-label) }} | |
| runs-on: ${{ inputs.runner-label }} |
| required: false | ||
| default: 'plugin_wheels' | ||
| type: string | ||
| extra-cr-tag: |
| df -h | ||
| rocm-smi -a || true | ||
| rocminfo | grep gfx || true | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
We should be using v6+ on actions/checkou or pinned hashes
| rocminfo | grep gfx || true | ||
| - uses: actions/checkout@v4 | ||
| - name: Download wheel artifacts | ||
| uses: actions/download-artifact@v4 |
There was a problem hiding this comment.
Same. Needs a relevant version and pinned hash
| ROCM_DEB_REPO=${ROCM_DEB_REPO_HOME}${ROCM_VERS}/ | ||
| AMDGPU_DEB_REPO=${AMDGPU_DEB_REPO_HOME}${AMDGPU_REPO_VERS}/ | ||
|
|
||
| DEBIAN_FRONTEND=noninteractive apt-get --allow-unauthenticated update |
There was a problem hiding this comment.
git diff --check says there's a trailing whitspace
|
do we need to put this to jax upstream? not sure what's sync policy in rocm/jax? |
hsharsha
changed the title
|
We keep our infra in another repository. So maybe we should close this PR and open one there. Nevertheless, the right approach seems to have hermetic root in the build, right @alekstheod ? |
4 participants
Add docker image to build and test JAX and XLA using hermetic llvm and sysroot based on ub22 image used for ml-build images