Implementing propper logging using ROOT's TError class. Chan… - #137
Merged
Conversation
…ges are AI-generated
fschlueter
changed the title
Contributor
|
I think this looks good and is reasonable, then can redirect with the rest of ROOT messages, etc. I guess one question is if we should use the ROOT gDebug rather than our own verbose flag, but our own verbose flag is probably more useful. |
cozzyd
approved these changes
Jul 6, 2026
Contributor
Author
|
@cozzyd I added a few more things but I will go ahead and merge this. Please object if you want! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ges are AI-generated.
This PR is not based on #136. If we decide to go with #136 we will have to deal with some merge conflicts...