Skip to content

Add RL-Kernel linear_logp integration with TP2 benchmark config#2

Draft
inaniloquentee wants to merge 1 commit into
mainfrom
vime-rlk-tp2-integration
Draft

Add RL-Kernel linear_logp integration with TP2 benchmark config#2
inaniloquentee wants to merge 1 commit into
mainfrom
vime-rlk-tp2-integration

Conversation

@inaniloquentee

Copy link
Copy Markdown
Collaborator

Summary

  • Add RL-Kernel linear_logp integration and tests from the current integration PR.
  • Configure the Qwen3-30B-A3B benchmark path for TP=2.
  • Keep the rest of the benchmark config aligned with vime-RLK.md.
  • Exclude experiments/ artifacts and result files from this PR.

Config changes

  • Changed MEGATRON_TP from 8 to 2 in scripts/run-qwen3-30B-A3B.sh.
  • Updated the two MEGATRON_TP examples in vime-RLK.md from 8 to 2.
  • Left the remaining benchmark config unchanged from vime-RLK.md: NUM_GPUS=8, MEGATRON_EP=8, MEGATRON_CP=1, ROLLOUT_NUM_GPUS_PER_ENGINE=8, ROLLOUT_BATCH_SIZE=32, N_SAMPLES_PER_PROMPT=8, GLOBAL_BATCH_SIZE=256, MAX_TOKENS_PER_GPU=20480, and VLLM_GPU_MEMORY_UTILIZATION=0.7.

Tests

  • PYTHONPATH=$PWD pytest tests/test_rl_kernel_args.py tests/test_rl_kernel_linear_logp_integration.py tests/test_rl_kernel_logp_integration.py -q — 26 passed, 1 warning.
  • PYTHONPATH=$PWD pytest tests/test_rl_kernel_args.py tests/test_rl_kernel_linear_logp_integration.py tests/test_value_temperature.py tests/test_metric_report.py -q — 41 passed, 1 warning.
  • pre-commit run --files ... — passed.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea2ec6cb-bae7-4a58-b2ab-88b362c66928

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vime-rlk-tp2-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant