Update setup.py#172
Open
jazzpher wants to merge 1 commit into
Open
Conversation
jazzpher
commented
Oct 24, 2023
jazzpher
commented
- Add comments to explain various sections and functions.
- Check Python version compatibility using six for a more concise and maintainable approach.
- Utilize triple-quoted strings for docstrings to enhance documentation.
- Employ f-strings for improved string formatting.
- Use the with statement for file handling, ensuring files are properly closed.
- Improve error handling by using subprocess.run to capture results and check for errors.
- Utilize a list comprehension for the keywords list, making it more concise.
- Specify the required Python version in the setup script using python_requires.
- Add comments to explain various sections and functions. - Check Python version compatibility using six for a more concise and maintainable approach. - Utilize triple-quoted strings for docstrings to enhance documentation. - Employ f-strings for improved string formatting. - Use the with statement for file handling, ensuring files are properly closed. - Improve error handling by using subprocess.run to capture results and check for errors. - Utilize a list comprehension for the keywords list, making it more concise. - Specify the required Python version in the setup script using python_requires.
|
it would have been nice to merge this, so pyflux can install on Python-3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.