Skip to content

sys/crypto: add ACCESS() attribute#22371

Open
maribu wants to merge 2 commits into
RIOT-OS:masterfrom
maribu:sys/crypto/add-access-attribute
Open

sys/crypto: add ACCESS() attribute#22371
maribu wants to merge 2 commits into
RIOT-OS:masterfrom
maribu:sys/crypto/add-access-attribute

Conversation

@maribu

@maribu maribu commented Jun 10, 2026

Copy link
Copy Markdown
Member

Contribution description

  • annotate functions using the ACCESS() macro with the access attribute so that GCC can emit proper -Wstringop-overflow warnings
  • some drive-by doxygen markup fixes

Testing procedure

The CI will do this

Issues/PRs references

#22368

Declaration of AI-Tools / LLMs usage:

Same as in #22368

@maribu maribu added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 10, 2026
@github-actions github-actions Bot added the Area: sys Area: System label Jun 10, 2026
@riot-ci

riot-ci commented Jun 10, 2026

Copy link
Copy Markdown

Murdock results

✔️ PASSED

38be0a4 sys/net/nanocoap: fix compilation with LLVM 21

Success Failures Total Runtime
11124 0 11124 11m:06s

Artifacts

@maribu maribu force-pushed the sys/crypto/add-access-attribute branch from e46d696 to 6ce7725 Compare June 10, 2026 18:33
Comment thread sys/include/crypto/aes.h
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/chacha.h Outdated
Comment thread sys/include/crypto/chacha20poly1305.h
Comment thread sys/include/crypto/chacha20poly1305.h
Comment thread sys/include/crypto/poly1305.h
Comment thread sys/include/crypto/chacha.h Outdated
@maribu maribu force-pushed the sys/crypto/add-access-attribute branch 3 times, most recently from 9807fb3 to e586845 Compare June 10, 2026 21:08
@maribu maribu requested a review from miri64 as a code owner June 11, 2026 07:00
@github-actions github-actions Bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations labels Jun 11, 2026
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/aes.h Outdated
Comment thread sys/include/crypto/chacha.h Outdated
Comment thread sys/include/crypto/chacha20poly1305.h Outdated
Comment thread sys/include/crypto/chacha20poly1305.h Outdated
@maribu maribu force-pushed the sys/crypto/add-access-attribute branch 2 times, most recently from bb3a25f to 891900c Compare June 11, 2026 12:26
maribu and others added 2 commits June 11, 2026 14:27
- annotate functions using the `ACCESS()` macro with the `access`
  attribute so that GCC can emit proper `-Wstringop-overflow` warnings
- some drive-by doxygen markup fixes
- conversion of the license/copyright boiler plate to SPDX format

Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: Mikolai Gütschow <mikolai.guetschow@tu-dresden.de>
This fixes:

```
sys/net/application_layer/nanocoap/nanocoap.c:823:22: error: variable 'tkl_ext' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
  823 |         memcpy(buf, &tkl_ext, tkl_ext_len);
      |                      ^~~~~~~
```
@maribu maribu force-pushed the sys/crypto/add-access-attribute branch from 891900c to 38be0a4 Compare June 11, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants