core/thread_flags: collect predefined flags#22365
Conversation
|
Hey @axelixy, thank you for your first contribution! We really appreciate it! If you haven't already, please take a look at our contributing guidelines before the review process starts. Also, due to how the GitHub review system works, please avoid force-pushing or squashing your commits unless asked to by a maintainer (or unless your commit is still in "draft commit" stage). Your pull request will be reviewed as soon as possible. |
|
It looks like the tools-build failure is caused by a Docker pull failure. Could someone re-run that job? |
|
It looks like this PR is missing the |
There was a problem hiding this comment.
Some of these flags should not be centralized. Particularly the ones used in test apps, but also ones that are private to a module. There was some discussion about this on #riot-os:matrix.org. There is a link in issue #20867 to that discussion.
| #endif | ||
|
|
||
| #include "bitfield.h" | ||
| #include "thread_flags.h" |
There was a problem hiding this comment.
I don't believe this line is needed. I believe the only two users of POSIX_SELECT_THREAD_FLAG already include thread_flags.h, correct?
Contribution description
This centralizes RIOT's predefined thread flag definitions in
core/include/thread_flags.h.The PR moves the thread flag definitions listed in #20867 out of individual
modules and test applications, while preserving their existing bit values.
THREAD_FLAG_PREDEFINED_MASKnow also accounts for module-specific predefinedflags when the corresponding module is selected.
The updated mask includes flags used by event queues, USBUS, POSIX select,
Kinetis I2C, KW41ZRF, LVGL, lwIP netdev, and the listed test applications.
Testing procedure
I checked the diff locally with:
Issues/PRs references
Fixes #20867