cpu/riscv_common: move trap print to specific debug define#22362
Open
AnnsAnns wants to merge 3 commits into
Open
cpu/riscv_common: move trap print to specific debug define#22362AnnsAnns wants to merge 3 commits into
AnnsAnns wants to merge 3 commits into
Conversation
github-actions
Bot
added
Platform: RISC-V
AnnsAnns
added
the
CI: ready for build
crasbe
added
the
Type: enhancement
crasbe
reviewed
Jun 9, 2026
Co-authored-by: crasbe <crasbe@gmail.com>
mguetschow
reviewed
Jun 9, 2026
Comment on lines
+41
to
+42
| #ifndef PRINT_VERBOSE_TRAP_INFO | ||
| # define PRINT_VERBOSE_TRAP_INFO 0 |
Contributor
There was a problem hiding this comment.
Isn't that a typical configuration knob that should be prefixed with CONFIG_ (and also be available through Kconfig)?
AnnsAnns
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While extremely useful in some scenarios, the trap print would cause massive performance degradation when
DEVELHELPusually wouldn't. When this was originally added I targeted my specific niche issues but when developing an application that doesn't directly deal with traps it would completely clog the entire output.Testing procedure
Issues/PRs references
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: