dist/tools/check_pr: also error on Github commits

[mguetschow]

Contribution description

Right now, fixup commits usually just error out because they go over the commit message length limit. Automatic Github commits ("Apply suggestions from code review") just fail because they are missing the colon. Now we show the typical "squash needed" message instead.

Testing procedure

CI should fail on this PR until I remove the fixup commit.

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

• none

[mguetschow]

Ah, overlooked dist/tools/pr_check

[AnnsAnns]

This sounds solid but as far as I understand your test should not work since it checks out master for the commit-msg CI workflow and not the PR itself 😄

[crasbe]

This is handeled by https://github.com/RIOT-OS/RIOT/tree/master/dist/tools/pr_check

[AnnsAnns]

Ah, overlooked dist/tools/pr_check

I think there is still some value to making the commit-msg error clearer though

[crasbe]

Ah, overlooked dist/tools/pr_check

I think there is still some value to making the commit-msg error clearer though

Clearer?

[AnnsAnns]

Clearer?

In the sense that https://github.com/RIOT-OS/RIOT/actions/runs/27146516631/job/80125660302?pr=22358 would also show a message about it being a fixup.

I'd argue that it might actually make more sense to make commit-msg wait for pr_check though so that it doesn't throw like 3 CI errors for a single issue

[mguetschow]

I've changed the proposal now to what I initially wanted to cover: Erroring out on automatic "Github code review application" commits.

[riot-ci]

Murdock results

✔️ PASSED

ca292bf Apply suggestions from code review

Success	Failures	Total	Runtime
1	0	1	01m:18s

Artifacts

• Documentation preview

[crasbe]

Can you test that in this PR real quick? Add a bogus commit with "Apply suggestions from code review"?

[mguetschow]

Actually I just noted that Github would suggest "Apply suggestion from " for single apply instead of batch-apply. See the last commit to catch both.