pkg/lwip: add stm32_eth_link_up as dependency of lwip_ipv6#22344
Merged
Conversation
basilfx
added
Impact: minor
github-actions
Bot
added
Platform: ARM
basilfx
force-pushed
the
feature/lwip_ipv6_stm32
branch
from
c000c2c to
d3b1ace
Compare
crasbe
approved these changes
Jun 4, 2026
crasbe
left a comment
crasbe
left a comment
Contributor
There was a problem hiding this comment.
I did not test this myself, but considering you did significant work in this area, I trust your testing.
Also, getting module dependency resolution out of the CPU specific Makefiles is always good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This moves the inclusion of
stm32_eth_link_upforlwip_ipv6topkg/lwip, so that it now combines with the same inclusion forlwip_dhcp_auto.With #22305 and #22306, I have added
lpc1768_eth_link_upandefm32_eth_link_up, which would otherwise scatter lwIP-specific dependencies around incpu/*/Makefile.dep.Testing procedure
Run the following for current
masterand this branch.The
info-buildtarget should mentionstm32_eth_link_upas being included for both builds.Then comment the change in
pkg/lwip/Makefile.depand run the build again. Observe that it is not included.The chosen example is one that uses lwIP with IPv6.
Issues/PRs references
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: