Skip to content

sys/[a-h]*: replaced license headers with SPDX format#22323

Open
N11cc00 wants to merge 7 commits into
RIOT-OS:masterfrom
N11cc00:spdx-sys-a-h
Open

sys/[a-h]*: replaced license headers with SPDX format#22323
N11cc00 wants to merge 7 commits into
RIOT-OS:masterfrom
N11cc00:spdx-sys-a-h

Conversation

@N11cc00

@N11cc00 N11cc00 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Contribution description

This PR attempts to convert all license headers for all folders inside the sys/ directory starting with the letters A to H. Vendor specific files are left untouched as well as some files missing some copyright or license information.

Testing procedure

To check for correct license/copyright information in all files that are not vendor provided, use this command:

reuse lint -l | grep "^sys/" | grep -v "/vendor/"

Declaration of AI-Tools / LLMs usage

AI-Tools / LLMs that were used are:

  • VS Code Copilot for the python script

Issues/PRs references

Tracking #21515

@github-actions github-actions Bot added Area: timers Area: timer subsystems Area: arduino API Area: Arduino wrapper API Area: sys Area: System Area: Kconfig Area: Kconfig integration labels May 26, 2026
@crasbe crasbe added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels May 26, 2026

@crasbe crasbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many errors in this PR. I think I went through about 1/4 of the files. Please check the other files yourself and fix the systematic errors for example with Kconfig files.

Comment thread sys/app_metadata/app_metadata.c Outdated
Comment thread sys/app_metadata/app_metadata.c
Comment thread sys/arduino/include/arduino_board.h
Comment thread sys/auto_init/auto_init.c
Comment thread sys/auto_init/auto_init.c
Comment thread sys/base64/base64.c Outdated
Comment thread sys/base64/base64.c
Comment thread sys/bloom/bloom.c
Comment thread sys/checksum/crc32.c Outdated
Comment thread sys/chunked_ringbuffer/Kconfig
@crasbe crasbe removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2026

@mguetschow mguetschow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fun, do you know https://isaiprofitable.com/?

Comment thread sys/app_metadata/app_metadata.c
Comment thread sys/arduino/include/arduino_board.h
Comment thread sys/auto_init/auto_init.c
Comment thread sys/auto_init/Kconfig
Comment thread sys/base64/base64.c
Comment thread sys/frac/frac.c
Comment thread sys/hashes/md5.c
Comment thread sys/hashes/md5.c Outdated
Comment thread sys/hashes/sha256.c Outdated
Comment thread sys/hashes/sha2xx_common.c Outdated

@crasbe crasbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be a bit more careful before marking comments as resolved if they are actually resolved or not...

Comment thread sys/app_metadata/app_metadata.c Outdated
Comment thread sys/chunked_ringbuffer/chunked_ringbuffer.c Outdated
Comment thread sys/chunked_ringbuffer/chunked_ringbuffer.c Outdated
Comment thread sys/congure/test/Kconfig.config
Comment thread sys/crypto/chacha20poly1305.c Outdated
Comment thread sys/div/div.c
Comment thread sys/evtimer/evtimer.c Outdated
Comment thread sys/evtimer/evtimer.c Outdated
Comment thread sys/frac/frac.c Outdated
Comment thread sys/hashes/sha1.c Outdated
@N11cc00

N11cc00 commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

I hate github because it does not seem to process the newly pushed changes 😞

@N11cc00

N11cc00 commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

I pushed an empty commit and now the PR has registered the update.

Comment thread sys/bloom/bloom.c
Comment thread sys/hashes/sha2xx_common.c Outdated
Comment thread sys/hashes/sha256.c Outdated
@N11cc00

N11cc00 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

This can be reviewed again

Comment thread sys/hashes/sha1.c
/* This code is public-domain - it is based on libcrypt
* placed in the public domain by Wei Dai and other contributors.
* SPDX-FileCopyrightText: 2016 Oliver Hahm <oliver.hahm@inria.fr>
* SPDX-FileCopyrightText: Implementation based on libcrypt that was released by Wei Dai et al. into the public domain.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* SPDX-FileCopyrightText: Implementation based on libcrypt that was released by Wei Dai et al. into the public domain.
* SPDX-FileCopyrightText: Implementation based on libcrypt that was released
by Wei Dai et al. into the public domain.

Long line, but I like this solution.

@crasbe crasbe requested a review from mguetschow June 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: arduino API Area: Arduino wrapper API Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: timers Area: timer subsystems CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants