fix: add PACKAGE-MANAGER support#260
Merged
Merged
Conversation
rhartuv
requested review from
IlonaShishov,
vbelouso and
zvigrinberg
as code owners
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
|
@rhartuv please resolve the merge conflict, and then I'll take a look |
Resolve SpdxParsingServiceTest conflict: keep PACKAGE-MANAGER hyphen test alongside upstream URL-encoded sha256 purl tests. Co-authored-by: Cursor <cursoragent@cursor.com>
zvigrinberg
approved these changes
Jul 7, 2026
zvigrinberg
left a comment
zvigrinberg
left a comment
Collaborator
There was a problem hiding this comment.
@rhartuv LGTM Approved.
Just squash and merge to keep only the fix title.
TY!.
Contributor
Author
|
@vbelouso PTAL 👯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SPDX parser interoperability: accept both PACKAGE_MANAGER and PACKAGE-MANAGER when extracting component purls from externalRefs. (See this link)
Some SPDX generators emit the hyphen form (per SPDX 2.3 schema), but the parser only matched the underscore form. That caused valid OCI components to be treated as unsupported or rejected entirely on upload.
Changes
SpdxParsingService: treat PACKAGE_MANAGER and PACKAGE-MANAGER equivalently viaisPackageManagerCategory()SpdxParsingServiceTest: add unit test for hyphen-form referenceCategorydocs/sbom-requirements.md: document both forms are acceptedopenspec/specs/upload-spdx-api/spec.md: update parser requirement and add scenarioSlack
Jira